Skip to content

GnuTests: remove Hurd specific test #15221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oech3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GnuTests: remove Hurd specific test #15221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions util/build-gnu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@
# Remove tests checking for --version & --help
# Not really interesting for us and logs are too big
sed -i '/tests\/help\/help-version.sh/ D' Makefile
# GNU/Hurd specific
sed -i '/tests\/id\/gnu-zero-uids.sh/ D' Makefile
touch gnu-built
fi

Expand Down Expand Up @@ -239,7 +241,7 @@
# we should not regress our project just to match what GNU is going.
# So, do some changes on the fly

# GNU uses read/write and the test depends on the fact that write:retval=1 losts byte due to read.

Check warning on line 244 in util/build-gnu.sh

View workflow job for this annotation

GitHub Actions / Style/spelling (ubuntu-latest, feat_os_unix) 

WARNING: `cspell`: Unknown word 'losts' (file:'util/build-gnu.sh', line:244)
# However, splice:retval=1 does not consume bytes in pipe. So verifying splice path needs different setup.
# Fire read/write code path by disabling splice
sed -i 's/-e trace=write /-e trace=write,splice -e fault=splice /' tests/tee/short-write.sh
Expand Down
4 changes: 0 additions & 4 deletions util/gnu-unfixable-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ rm/r-root.log
tail/inotify-race.log
tail/inotify-race2.log

# require_gnu_ is "test $(uname) = GNU"; skipped on Linux for GNU coreutils too.
id/gnu-zero-uids.log


# --- Require matching GNU's libc entry points ----------------------------
# LD_PRELOAD does fire for Rust binaries, but each of these overrides the one
# symbol GNU happens to call and self-skips otherwise. We would have to route
Expand Down
Loading