Skip to content

uucore: Implement QUOTING_STYLE: c-maybe - #15092

Merged
cakebaker merged 2 commits into
uutils:mainfrom
RenjiSann:quoting-c-maybe
Oct 13, 2026
Merged

cakebaker merged 2 commits into
uutils:mainfrom
RenjiSann:quoting-c-maybe

Conversation

@RenjiSann

Copy link
Copy Markdown
Collaborator

This PR implements the new quoting style c-maybe added by GNU 9.12.

@RenjiSann
RenjiSann requested a review from cakebaker October 5, 2026 12:14
@codspeed

codspeed Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 25.19%

⚠️ 123 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 399 untouched benchmarks
⏩ 70 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation factor_three_39_bit_primes 300.2 ms 516.8 ms -41.91%
❌ Simulation factor_five_38_bit_primes 1.6 s 1.7 s -3.66%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing RenjiSann:quoting-c-maybe (7463fc9) with main (98f90f2)

Open in CodSpeed

Footnotes

  1. 70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Comment thread src/uucore/src/lib/features/quoting_style/escaped_char.rs Outdated
Comment thread src/uucore/src/lib/features/quoting_style/c_quoter.rs Outdated
Comment thread src/uucore/src/lib/features/quoting_style/c_quoter.rs Outdated
Comment thread src/uucore/src/lib/features/quoting_style/mod.rs
Comment thread src/uucore/src/lib/features/quoting_style/mod.rs
@RenjiSann
RenjiSann force-pushed the quoting-c-maybe branch 2 times, most recently from a6455e8 to 38eafc8 Compare October 6, 2026 13:20
Comment thread src/uucore/src/lib/features/quoting_style/c_quoter.rs Outdated
Comment thread src/uucore/src/lib/features/quoting_style/c_quoter.rs Outdated
Comment thread src/uucore/src/lib/features/quoting_style/mod.rs
@RenjiSann
RenjiSann force-pushed the quoting-c-maybe branch 2 times, most recently from 2f82d7e to db62a85 Compare October 9, 2026 11:12
@RenjiSann
RenjiSann requested a review from sylvestre October 9, 2026 11:13
@sylvestre

Copy link
Copy Markdown
Contributor

rustfmt is sad :)
could you please run cargo fmt?

Diff in /home/runner/work/coreutils/coreutils/src/uucore/src/lib/features/quoting_style/c_quoter.rs:140:
         if escaped.is_escaping() {
             self.must_quote = true;
         }
-        self.buffer
-            .extend(escaped.collect::<String>().into_bytes());
+        self.buffer.extend(escaped.collect::<String>().into_bytes());
     }

     fn push_invalid(&mut self, input: &[u8]) {
##[endgroup]
     Removed 0 files
##[endgroup]
##[error]ssh exited with code 1
Post job cleanup.
[command]/usr/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/work/_temp/0b325b24-3965-46d3-b221-6787b6bc3688' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/bin/git config --global --add safe.directory /home/runner/work/coreutils/coreutils

Comment thread src/uucore/src/lib/features/quoting_style/c_quoter.rs Outdated
Comment thread src/uucore/src/lib/features/quoting_style/c_quoter.rs
@RenjiSann
RenjiSann force-pushed the quoting-c-maybe branch 2 times, most recently from acd6ba7 to 92ad39a Compare October 12, 2026 09:28
Comment thread tests/by-util/test_ls.rs Outdated
Comment thread tests/by-util/test_ls.rs
@RenjiSann
RenjiSann force-pushed the quoting-c-maybe branch 3 times, most recently from 8585613 to 9973d08 Compare October 12, 2026 15:15
@cakebaker
cakebaker merged commit 1747ba1 into uutils:main Oct 13, 2026
191 of 192 checks passed
@cakebaker

Copy link
Copy Markdown
Contributor

Thanks!

@RenjiSann
RenjiSann deleted the quoting-c-maybe branch October 13, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants