Repository navigation
refactor: use proc macro for wasi ignore reasons - #14964
eduardomourar wants to merge 1 commit into
Conversation
|
GNU testsuite comparison: |
2a36443 to
088a962
Compare
Merging this PR will regress 4 benchmarks
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
088a962 to
ab95f3f
Compare
5353ad6 to
7fc1254
Compare
7fc1254 to
764dc3f
Compare
There was a problem hiding this comment.
Maybe we can remove this whole file and add those as comments in tests/uutests_procs/src/lib.rs
Centralizes the ~400
#[cfg_attr(wasi_runner, ignore = "...")]annotations across the integration tests behind#[uutests::wasi_ignore(ReasonKey)], a proc-macro attribute defined in a newtests/uutests_procscrate.Context: As per PR 14884 and PR 13687 flagged
wasi_runneras a noisy, ad hoccfg. It can't be replaced withtarget_os, since the tests always compile for the host (WASI can't spawn the child process they launch) —wasi_runneris the only signal a run is driving awasm32-wasip1/wasm32-wasip2binary viawasmtime. This doesn't remove thecfg, just the string-literal duplication around it: every reason is now defined once, alphabetically, intests/uutests_procs/src/lib.rs42 keys, down from an initial 57 after merging duplicates), including several that previously had no explanation at all.#[uutests::wasi_ignore(Reason)]can also be applied to amod { ... }block instead of one#[test]fn at a time; it recurses into nested modules and attaches the reason to every test inside.tee'slinux_onlymodule (21 tests) andtruncate'sfifomodule (3 tests) use this instead of repeating the same key on every test.Not touched: structural gates that aren't ignore-reasons (
feat_diagnosticsmodule gating,#[cfg(wasi_runner)]branches selecting alternate passing assertions).