uucore: unify hard link detection across platforms using FileInformation by wtcpython · Pull Request #14784 · uutils/coreutils

wtcpython · 2026-09-21T13:13:25Z

Hard-link detection currently has separate Unix logic and always returns false on other platforms.

This reuses FileInformation for both hard-link checks, preserving the existing Unix behavior and enabling the same checks on Windows and WASI.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-09-21T18:09:02Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

sylvestre · 2026-09-21T18:23:56Z

 ///
 /// * `bool` - Returns `true` if the paths are hard links to the same file, and `false` otherwise.
-#[cfg(unix)]
 pub fn are_hardlinks_to_same_file(source: &Path, target: &Path) -> bool {


the unit tests below are still #[cfg(unix)], please enable them on windows too since the function now works there

sylvestre · 2026-09-21T18:24:02Z

 ///
 /// * `bool` - Returns `true` if either of above conditions are true, and `false` otherwise.
-#[cfg(unix)]
 pub fn are_hardlinks_or_one_way_symlink_to_same_file(source: &Path, target: &Path) -> bool {


on windows from_path actually opens the file, so a file we can't open now silently compares as "not the same" - is that ok for cp/mv?

sylvestre · 2026-09-21T18:24:12Z

@@ -790,23 +784,17 @@ pub fn are_hardlinks_to_same_file(_source: &Path, _target: &Path) -> bool {
 /// # Returns


CI is red (tests unix), could you please check it's not coming from this change? thanks

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

codspeed · 2026-10-09T03:03:53Z

Merging this PR will regress 2 benchmarks

⚠️

121 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

mv_multiple_to_dir

cksum_default

du_wide_tree[(5000, 500)]

cksum_multiple_files

cksum_crc32b

du_summarize_balanced_tree[(5, 4, 10)]

du_all_wide_tree[(5000, 500)]

cp_preserve_metadata[(5, 4, 10)]

cp_recursive_balanced_tree[(5, 4, 10)]

cp_recursive_wide_tree[(6000, 800)]

…and 111 more

ℹ️ 1 benchmark has no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

sort_dictionary_order[500000]

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 398 untouched benchmarks
⏩ 70 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Simulation	`factor_five_38_bit_primes`	1.8 s	2.2 s	-18.26%
❌	Simulation	`factor_thirteen_39_bit_primes`	8.7 s	9 s	-3.76%
⚡	Simulation	`factor_three_39_bit_primes`	800.7 ms	590.7 ms	+35.54%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing wtcpython:fs-unify-hardlink (47f49f3) with main (2fb77e8)²}

70 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (0982bd1) during the generation of this report, so 2fb77e8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

eduardomourar · 2026-10-13T10:02:30Z

    }

-    #[cfg(unix)]
+    #[cfg(not(target_os = "wasi"))]


This gate was widened to include Windows, but it uses Unix-only imports that aren't in scope here. Its body calls tempdir() and unix::fs::symlink(...), but both use std::os::unix; and use tempfile::tempdir; in the test module remain gated behind #[cfg(unix)] only (unchanged by this PR).

Reproduced with cargo check -p uucore --tests --target x86_64-pc-windows-gnu --no-default-features --features fs:

error[E0433]: cannot find module or crate unix in this scope
--> src/uucore/src/lib/features/fs.rs:1400:9
error[E0425]: cannot find function tempdir in this scope
--> src/uucore/src/lib/features/fs.rs:1396:24

Created this #15301 to ensure uucore is checked on Windows.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Copilot AI lite review requested due to automatic review settings September 21, 2026 13:13

Copilot AI reviewed Sep 21, 2026

sylvestre force-pushed the fs-unify-hardlink branch from 38a95a3 to 82ff922 Compare September 21, 2026 18:23

Copilot AI review requested due to automatic review settings September 21, 2026 18:23

Copilot AI reviewed Sep 21, 2026

sylvestre reviewed Sep 21, 2026

View reviewed changes

wtcpython force-pushed the fs-unify-hardlink branch from 82ff922 to 2f7dc47 Compare September 21, 2026 23:59

Copilot AI review requested due to automatic review settings September 21, 2026 23:59

Copilot AI reviewed Sep 21, 2026

Copilot AI review requested due to automatic review settings September 22, 2026 03:04

wtcpython force-pushed the fs-unify-hardlink branch from 2f7dc47 to 9df2922 Compare September 22, 2026 03:04

Copilot AI reviewed Sep 22, 2026

Copilot AI lite review requested due to automatic review settings October 9, 2026 00:31

wtcpython force-pushed the fs-unify-hardlink branch from 9df2922 to 09c01f9 Compare October 9, 2026 00:31

Copilot AI reviewed Oct 9, 2026

Copilot AI lite review requested due to automatic review settings October 10, 2026 15:15

wtcpython force-pushed the fs-unify-hardlink branch from 09c01f9 to 46a78a1 Compare October 10, 2026 15:15

Copilot AI reviewed Oct 10, 2026

eduardomourar suggested changes Oct 13, 2026

View reviewed changes

Copilot AI lite review requested due to automatic review settings October 14, 2026 09:05

wtcpython force-pushed the fs-unify-hardlink branch from 46a78a1 to b06218d Compare October 14, 2026 09:05

Copilot AI reviewed Oct 14, 2026

Copilot AI lite review requested due to automatic review settings October 14, 2026 09:28

wtcpython force-pushed the fs-unify-hardlink branch from b06218d to 7506795 Compare October 14, 2026 09:28

Copilot AI reviewed Oct 14, 2026

uucore: unify hard link detection across platforms using FileInformation

47f49f3

wtcpython force-pushed the fs-unify-hardlink branch from 7506795 to 47f49f3 Compare October 15, 2026 08:04

Copilot AI lite review requested due to automatic review settings October 15, 2026 08:04

Copilot AI reviewed Oct 15, 2026

		@@ -790,23 +784,17 @@ pub fn are_hardlinks_to_same_file(_source: &Path, _target: &Path) -> bool {
		/// # Returns

Conversation

wtcpython commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sylvestre Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will regress 2 benchmarks

Performance Changes

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

eduardomourar Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

eduardomourar Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Sep 21, 2026 •

edited

Loading

codspeed Bot commented Oct 9, 2026 •

edited

Loading