Repository navigation
Conversation
|
We remove it at #11579 . |
|
Binary size comparison: |
|
GNU testsuite comparison: |
Merging this PR will regress 7 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | five_38_bit_primes |
1.5 s | 1.8 s | -16.61% |
| ❌ | Simulation | expand_many_lines[100000] |
95 ms | 106.2 ms | -10.53% |
| ❌ | Simulation | tsort_complex_dag[50000] |
87.6 ms | 97.2 ms | -9.79% |
| ❌ | Simulation | expand_custom_tabstops[50000] |
26.9 ms | 29.6 ms | -9.27% |
| ❌ | Simulation | tsort_tree_dag[(10, 3)] |
36.5 ms | 39.4 ms | -7.34% |
| ❌ | Simulation | tsort_wide_dag[100000] |
157.6 ms | 167 ms | -5.64% |
| ❌ | Simulation | tsort_linear_chain[1000000] |
1.9 s | 2 s | -4.75% |
| ⚡ | Simulation | three_39_bit_primes |
901.6 ms | 378.6 ms | ×2.4 |
| ⚡ | Simulation | join_french_locale |
26.7 ms | 24 ms | +11.09% |
| ⚡ | Simulation | join_full_match |
26.7 ms | 24 ms | +11.08% |
| ⚡ | Simulation | join_partial_overlap |
22.1 ms | 20.4 ms | +8.36% |
| ⚡ | Simulation | join_unicode_locale |
2.6 ms | 2.4 ms | +6.65% |
| ⚡ | Simulation | join_custom_separator |
25.9 ms | 24.4 ms | +6.08% |
| ⚡ | Simulation | rm_recursive_tree |
14.4 ms | 13.7 ms | +5.28% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing xtqqczze:feat_systemd_logind (f986fd3) with main (fe26d56)2
Footnotes
-
62 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
main(a5bc606) during the generation of this report, so fe26d56 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
ce647a1 to
3cf5970
Compare
3cf5970 to
10225c8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
10225c8 to
658d6d9
Compare
b1c3a47 to
e68a24b
Compare
|
I think |
|
@sylvestre Regardless of whether #11579 is desirable (and I think it probably is), I still think we should merge this in the meantime. The merge conflicts should be straightforward to resolve. |
|
@sylvestre Could you merge this please; I have changes depending on this. |
e68a24b to
6287a57
Compare
0bf8d45 to
feb5727
Compare
|
@sylvestre ready |
feb5727 to
f986fd3
Compare
|
I like |
Currently we are not using general |
|
It is not matter since we use openssl instead of openssl_api_name for cksum.
|
I think we have a feature named |
Rename the
feat_systemd_logindfeature tosystemd_logind.Prevent
systemd_logindcode from being enabled on unsupported platforms, improving cross-platform compilation and bringing the workspace closer to supporting: