sort: defer compress program errors until needed by wtcpython · Pull Request #13656 · uutils/coreutils

wtcpython · 2026-07-30T15:00:10Z

Defer reporting compression program errors until external sorting is required, allowing earlier input errors to be reported without an unrelated compression warning.

github-actions · 2026-07-30T15:38:15Z

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)

codspeed · 2026-08-05T10:21:05Z

Merging this PR will not alter performance

⚠️

28 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

sort_unique_utf8_locale

sort_reverse_locale[500000]

sort_long_line[10000]

sort_long_common_prefix_utf8_locale

sort_spill_to_tmp_files_utf8_locale

merge_pre_sorted_files

sort_ascii_utf8_locale

merge_pre_sorted_files_utf8_locale

merge_single_file_utf8_locale

sort_case_sensitive[500000]

…and 18 more

✅ 58 untouched benchmarks
⏩ 414 skipped benchmarks¹

_{Comparing wtcpython:sort-compress-error-priority (c32ebba) with main (7654e67)²}

414 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (0982bd1) during the generation of this report, so 7654e67 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

github-actions · 2026-08-14T03:47:03Z

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 148.97 MB (-132 KB, -0.09%)

Significant per-binary changes:
  [           1.10 MB ->    1.18 MB  (+76 KB, +6.74%)
  test        1.10 MB ->    1.18 MB  (+76 KB, +6.74%)
  install     1.25 MB ->    1.32 MB  (+72 KB, +5.62%)
  mkdir       1.10 MB ->    1.17 MB  (+72 KB, +6.38%)
  mkfifo      1.09 MB ->    1.16 MB  (+72 KB, +6.45%)
  mknod       1.10 MB ->    1.17 MB  (+72 KB, +6.41%)
  chmod       1.15 MB ->    1.22 MB  (+68 KB, +5.76%)

wtcpython · 2026-08-16T14:09:15Z

Would you mind taking a look when convenient? Thanks!

sylvestre · 2026-08-16T14:20:27Z

+    if let Some((prog, err)) = compress_prog_error {
+        let _ = writeln!(
+            stderr(),
+            "sort: could not run compress program '{prog}': {}",


Please use the translate macro

sylvestre · 2026-08-16T14:20:41Z

            "nonexistent-program",
            "-S",
-            "10",
+            "1K",


Seems unrelated

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 3 · 1

Open (4)

Emitting the warning via show_error! from the reader/writer thread can cause non-deterministic… · New
Emitting the warning via show_error! from the reader/writer thread can cause non-deterministic… · New
The assertion .stderr_contains(\"Is a directory\") is potentially brittle across… · New
This relies on ext_sort.txt being large enough to exceed the in-memory threshold (effectively the… · New

+#[allow(clippy::too_many_arguments)]
 fn read_write_loop<I: WriteableTmpFile>(
    mut files: impl Iterator<Item = UResult<Box<dyn Read + Send>>>,
    tmp_dir: &mut TmpDirWrapper,
    separator: u8,
    buffer_size: usize,
    settings: &GlobalSettings,
+    compress_prog_error: Option<(String, std::io::Error)>,
    receiver: &Receiver<Chunk>,
    sender: SyncSender<Chunk>,
 ) -> UResult<ReadResult<I>> {


+    // The input did not fit into the first two in-memory chunks.
+    if let Some((prog, err)) = compress_prog_error {
+        show_error!(
+            "{}",
+            translate!(
+                "sort-compress-prog-execution-failed",
+                "prog" => prog,
+                "error" => strip_errno(&err)
+            )
+        );
+    }


+    ucmd.args(&["--compress-program=nonexistent", "input", "directory"])
+        .fails_with_code(2)
+        .no_stdout()
+        .stderr_contains("Is a directory")


+            // Force external sorting by using 1K buffer size so ext_sort.txt spills to disk
            "-S",
-            "10",
+            "1K",


Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

wtcpython force-pushed the sort-compress-error-priority branch from d468737 to 8ab9b62 Compare August 5, 2026 09:35

wtcpython force-pushed the sort-compress-error-priority branch 3 times, most recently from 828477d to 95b0ea3 Compare August 10, 2026 15:00

wtcpython force-pushed the sort-compress-error-priority branch from 95b0ea3 to 9fe5d79 Compare August 14, 2026 03:20

wtcpython force-pushed the sort-compress-error-priority branch from 9fe5d79 to d14f018 Compare August 16, 2026 13:56

sylvestre reviewed Aug 16, 2026

View reviewed changes

Comment thread tests/by-util/test_sort.rs

"nonexistent-program",

"-S",

"10",

"1K",

sylvestre Aug 16, 2026

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unrelated

wtcpython force-pushed the sort-compress-error-priority branch from d14f018 to a97b03b Compare August 17, 2026 00:02

wtcpython force-pushed the sort-compress-error-priority branch 2 times, most recently from d077b2a to 03ee9d6 Compare August 31, 2026 01:23

wtcpython force-pushed the sort-compress-error-priority branch from 03ee9d6 to 32a1dae Compare September 15, 2026 09:30

Copilot AI lite review requested due to automatic review settings September 15, 2026 09:30

Copilot AI reviewed Sep 15, 2026

wtcpython force-pushed the sort-compress-error-priority branch from 32a1dae to 596981d Compare September 19, 2026 01:38

Copilot AI review requested due to automatic review settings September 19, 2026 01:38

Copilot AI reviewed Sep 19, 2026

wtcpython force-pushed the sort-compress-error-priority branch from 596981d to 1b214b2 Compare September 24, 2026 07:39

Copilot AI review requested due to automatic review settings September 24, 2026 07:39

Copilot AI reviewed Sep 24, 2026

wtcpython force-pushed the sort-compress-error-priority branch from 1b214b2 to f936598 Compare September 25, 2026 00:55

Copilot AI review requested due to automatic review settings September 25, 2026 00:55

Copilot AI reviewed Sep 25, 2026

Copilot AI review requested due to automatic review settings September 27, 2026 00:39

wtcpython force-pushed the sort-compress-error-priority branch from f936598 to 25b047d Compare September 27, 2026 00:39

Copilot AI reviewed Sep 27, 2026

wtcpython force-pushed the sort-compress-error-priority branch from 25b047d to ba7cfef Compare September 29, 2026 06:09

Copilot AI review requested due to automatic review settings September 29, 2026 06:09

Copilot AI reviewed Sep 29, 2026

wtcpython force-pushed the sort-compress-error-priority branch from ba7cfef to ac8524a Compare September 30, 2026 03:20

Copilot AI lite review requested due to automatic review settings September 30, 2026 03:20

Copilot AI reviewed Sep 30, 2026

Copilot AI lite review requested due to automatic review settings October 1, 2026 11:40

wtcpython force-pushed the sort-compress-error-priority branch from ac8524a to c4a433d Compare October 1, 2026 11:40

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Copilot started reviewing on behalf of wtcpython October 1, 2026 12:32

View session

wtcpython force-pushed the sort-compress-error-priority branch from c4a433d to 8b27135 Compare October 2, 2026 10:41

Copilot AI lite review requested due to automatic review settings October 2, 2026 10:41

Copilot AI reviewed Oct 2, 2026

wtcpython force-pushed the sort-compress-error-priority branch from 8b27135 to 5414b34 Compare October 4, 2026 01:16

Copilot AI lite review requested due to automatic review settings October 4, 2026 01:16

Copilot AI reviewed Oct 4, 2026

Copilot AI lite review requested due to automatic review settings October 9, 2026 00:31

wtcpython force-pushed the sort-compress-error-priority branch from 5414b34 to 8b595dd Compare October 9, 2026 00:31

Copilot AI reviewed Oct 9, 2026

Copilot AI lite review requested due to automatic review settings October 10, 2026 15:15

wtcpython force-pushed the sort-compress-error-priority branch from 8b595dd to f68ad56 Compare October 10, 2026 15:15

Copilot AI reviewed Oct 10, 2026

sort: defer compress program errors until needed

c32ebba

wtcpython force-pushed the sort-compress-error-priority branch from f68ad56 to c32ebba Compare October 15, 2026 08:04

Copilot AI lite review requested due to automatic review settings October 15, 2026 08:04

Copilot AI reviewed Oct 15, 2026

Conversation

wtcpython commented Jul 30, 2026

Uh oh!

github-actions Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

github-actions Bot commented Aug 14, 2026

Uh oh!

wtcpython commented Aug 16, 2026

Uh oh!

sylvestre Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

sylvestre Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Jul 30, 2026 •

edited

Loading

codspeed Bot commented Aug 5, 2026 •

edited

Loading