Compile errors with --all-features on non-Linux

In pre-commit hook we have:

Line 43 in d09f351

    
           entry: cargo +stable clippy --workspace --all-targets --all-features -- -D warnings

but currently this fails on non-Linux systems:

cargo clippy --workspace --all-targets --all-features

error[E0433]: failed to resolve: could not find `selinux` in `uucore`
   --> src/uu/id/src/id.rs:145:36
    |
145 |         selinux_supported: uucore::selinux::is_selinux_enabled(),
    |                                    ^^^^^^^ could not find `selinux` in `uucore`

error[E0433]: failed to resolve: could not find `smack` in `uucore`
   --> src/uu/id/src/id.rs:198:27
    |
198 |             match uucore::smack::get_smack_label_for_self() {
    |                           ^^^^^ could not find `smack` in `uucore`

error[E0425]: cannot find value `uumain` in crate `chcon`
   --> target/debug/build/coreutils-dbc4be9239a5e04a/out/uutils_map.rs:152:27
    |
152 |         ("chcon", (chcon::uumain, chcon::uu_app)),
    |                           ^^^^^^ not found in `chcon`

etc

You should install SELinux related header packages on the system. We cannot fix it at cargo side.

You should install SELinux related header packages on the system. We cannot fix it at cargo side.

#11016 will fix selinux/smack errors for non-Linux platforms.

@oech3

You should install SELinux related header packages on the system.

@oech3 Is this possible on non-Linux systems?

~~depending on Linux distribution what you use.~~ No

$ cargo clippy --workspace --all-targets --all-features -q --keep-going
error[E0425]: cannot find value `uumain` in crate `chcon`
   --> target/debug/build/coreutils-f72911ea23e264cf/out/uutils_map.rs:152:27
    |
152 |         ("chcon", (chcon::uumain, chcon::uu_app)),
    |                           ^^^^^^ not found in `chcon`

error[E0425]: cannot find value `uu_app` in crate `chcon`
   --> target/debug/build/coreutils-f72911ea23e264cf/out/uutils_map.rs:152:42
    |
152 |         ("chcon", (chcon::uumain, chcon::uu_app)),
    |                                          ^^^^^^ not found in `chcon`

error[E0425]: cannot find value `uumain` in crate `runcon`
   --> target/debug/build/coreutils-f72911ea23e264cf/out/uutils_map.rs:214:29
    |
214 |         ("runcon", (runcon::uumain, runcon::uu_app)),
    |                             ^^^^^^ not found in `runcon`

error[E0425]: cannot find value `uu_app` in crate `runcon`
   --> target/debug/build/coreutils-f72911ea23e264cf/out/uutils_map.rs:214:45
    |
214 |         ("runcon", (runcon::uumain, runcon::uu_app)),
    |                                             ^^^^^^ not found in `runcon`

This issue does not making a sense for me.
Platform specific feature is guarded by Cargo.toml to prevent error.
But --all-features means you are deliberately breaking it. In the cases, it is natural to cause eror.

I guess there are many missing utils making some sense on "native" Windows for people on MSYS2.

But why should we support this?
[Edit] Just guard this part of hook by Linux

cargo clippy --workspace --all-targets --all-features is now successful for macOS, #12386 will enforce in CI.

Navigation Menu

Repository navigation

Compile errors with `--all-features` on non-Linux #11019

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Compile errors with --all-features on non-Linux #11019

Description

Activity

oech3 commented on Feb 18, 2026

xtqqczze commented on Feb 18, 2026

xtqqczze commented on Feb 18, 2026

oech3 commented on Feb 18, 2026

xtqqczze commented on Apr 29, 2026

oech3 commented on May 16, 2026

oech3 commented on May 17, 2026

oech3 commented on May 17, 2026

xtqqczze commented on May 19, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Compile errors with `--all-features` on non-Linux #11019