Skip to content

feat(editor): add consistent transient UI motion - #70

Closed
utpalsinghdev wants to merge 1 commit into
mainfrom
feat/issue-66-editor-motion
Closed

utpalsinghdev wants to merge 1 commit into
mainfrom
feat/issue-66-editor-motion

Conversation

@utpalsinghdev

Copy link
Copy Markdown
Owner

Summary

Opening Review and dropdowns was abrupt during ordinary editing. This adds shared 160 ms ease-out entrances and 100 ms ease-in exits without delaying actions or changing artwork.

Review and notifications retain only inert, pointer-transparent content during exit. File and Export keep native details behavior. Help, Projects and narrow panels get brief entrances with immediate dismissal; desktop sidebar geometry stays instant.

Linked issue

Closes #66

What users will see

Open Review, place a comment, read a conversation, or open File/Export to see brief, consistent transitions. Reduced motion skips effects, including when the preference changes during an animation. Existing shortcuts and dismissal behavior stay intact.

Affected areas

  • Editor UI, navigation, or keyboard controls
  • Document schema, migration, assets, or native backup format
  • Commands, rendering, layout, or undo/redo
  • MCP tools, targets, revisions, or capabilities
  • Saving, recovery, or concurrent editing
  • Import, export, fonts, or visual fidelity
  • Runtime, release, dependencies, or default access behavior
  • Contributor tooling or documentation

Export-menu presentation changes, not the exporter. This is editor chrome only: no new document capability or MCP surface is needed, and history, storage and artwork formats are unchanged.

Acceptance criteria

  • Review list/composer/conversation and File/Export entry and exit were sampled live in Brave. Review exit reaches zero opacity before removal without resetting to full opacity.
  • Escape, focus restoration, Tab/Shift+Tab, menu outside-click dismissal and closed-surface hit testing passed. Review retains its existing nonmodal outside-click behavior.
  • Rapid toggles, three Cancel/reopen cycles, list/thread switching and notification replacement/dismissal ended in the correct state.
  • Reduced motion passed before reload and when enabled during entry or exit. At 390 × 844, Layers/Review/Properties stayed exclusive, Properties scrolled internally and the page had no horizontal overflow.
  • Drawing/undo, pan, text entry/undo, a nonempty SVG export and JSON backup passed. The backup contained no UI motion properties. No loops or artwork animation were added.
  • The surface audit records motion choices and deliberately instant interactions, including native controls, recovery warnings and canvas geometry.

Reproduction

On b228b3f, open Review, place a comment, then open File and Export. Their containers had zero-duration motion, and Review disappeared immediately on close. The same workflows now use the shared timings while removing interaction immediately on dismissal.

Screenshots

Each pair shows Review composition and Export at the same viewport. These are settled states; motion and interruption were checked live, not inferred from still images.

Before, desktop 1440 × 1000

Before: desktop Review composer and Export menu

After, desktop 1440 × 1000

After: desktop Review composer and Export menu

Before, narrow 390 × 844

Before: narrow Review composer and Export menu

After, narrow 390 × 844

After: narrow Review composer and Export menu

Verification

Passed with Node 24.22.1 and pnpm 12.21.0:

  • corepack pnpm install --frozen-lockfile
  • corepack pnpm run check
  • corepack pnpm run build
  • corepack pnpm run changeset:status --since=origin/main
  • git diff --check

Real local Brave 151.1.93.136 covered desktop and narrow interactions above. The UI detector reported no findings. Existing Zod build annotation warnings remain. No new test files were added, per repository policy.

Docs and limits

Added docs/editor-motion.md, updated DESIGN.md, README and the verification record, and included a web patch Changeset.

Browsers without ::details-content/discrete-transition support keep native instant menu behavior. Mac, Safari/Firefox and physical touch hardware were not tested. Dialog and panel exits intentionally remain immediate rather than retaining modal blockers or stale panels.

@utpalsinghdev
utpalsinghdev marked this pull request as draft November 16, 2026 20:58
@utpalsinghdev

Copy link
Copy Markdown
Owner Author

Before merging this PR please explicitly ask me and also verify that all the other PRs are merged before we merge this because this PR contains UI motion consistent things and some other UI changes are implemented in some other peers so we need to re-implement this thing maybe like if the new things were added as for them that's why either merge it at very end after verifying or like I'll tell you what to do

@utpalsinghdev

Copy link
Copy Markdown
Owner Author

Superseded by #93, which keeps this commit and rebuilds the motion work on the current editor (including the #92 Review changes). Leaving this open until you decide to close it.

@utpalsinghdev

Copy link
Copy Markdown
Owner Author

Closing in favor of #93, which merged with this PR's commit preserved.

@utpalsinghdev utpalsinghdev mentioned this pull request Nov 19, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add consistent easing to editor overlays, menus, and transitions

1 participant