Repository navigation
feat(editor): add consistent transient UI motion - #70
Closed
utpalsinghdev wants to merge 1 commit into
Closed
utpalsinghdev wants to merge 1 commit into
utpalsinghdev wants to merge 1 commit into
Conversation
utpalsinghdev
marked this pull request as draft
November 16, 2026 20:58
Owner
Author
|
Before merging this PR please explicitly ask me and also verify that all the other PRs are merged before we merge this because this PR contains UI motion consistent things and some other UI changes are implemented in some other peers so we need to re-implement this thing maybe like if the new things were added as for them that's why either merge it at very end after verifying or like I'll tell you what to do |
2 of 8 tasks
Owner
Author
Owner
Author
|
Closing in favor of #93, which merged with this PR's commit preserved. |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opening Review and dropdowns was abrupt during ordinary editing. This adds shared 160 ms ease-out entrances and 100 ms ease-in exits without delaying actions or changing artwork.
Review and notifications retain only inert, pointer-transparent content during exit. File and Export keep native
detailsbehavior. Help, Projects and narrow panels get brief entrances with immediate dismissal; desktop sidebar geometry stays instant.Linked issue
Closes #66
What users will see
Open Review, place a comment, read a conversation, or open File/Export to see brief, consistent transitions. Reduced motion skips effects, including when the preference changes during an animation. Existing shortcuts and dismissal behavior stay intact.
Affected areas
Export-menu presentation changes, not the exporter. This is editor chrome only: no new document capability or MCP surface is needed, and history, storage and artwork formats are unchanged.
Acceptance criteria
Reproduction
On
b228b3f, open Review, place a comment, then open File and Export. Their containers had zero-duration motion, and Review disappeared immediately on close. The same workflows now use the shared timings while removing interaction immediately on dismissal.Screenshots
Each pair shows Review composition and Export at the same viewport. These are settled states; motion and interruption were checked live, not inferred from still images.
Before, desktop 1440 × 1000
After, desktop 1440 × 1000
Before, narrow 390 × 844
After, narrow 390 × 844
Verification
Passed with Node 24.22.1 and pnpm 12.21.0:
corepack pnpm install --frozen-lockfilecorepack pnpm run checkcorepack pnpm run buildcorepack pnpm run changeset:status --since=origin/maingit diff --checkReal local Brave 151.1.93.136 covered desktop and narrow interactions above. The UI detector reported no findings. Existing Zod build annotation warnings remain. No new test files were added, per repository policy.
Docs and limits
Added
docs/editor-motion.md, updatedDESIGN.md, README and the verification record, and included a web patch Changeset.Browsers without
::details-content/discrete-transition support keep native instant menu behavior. Mac, Safari/Firefox and physical touch hardware were not tested. Dialog and panel exits intentionally remain immediate rather than retaining modal blockers or stale panels.