fix postgresql: validate bit length in bitstring parser - #1346
Open
netliomax25-code wants to merge 1 commit into
Open
fix postgresql: validate bit length in bitstring parser#1346netliomax25-code wants to merge 1 commit into
netliomax25-code wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bit/bit varyingbinary parser (BufferParserforBitStringRefWrapperinpostgresql/include/userver/storages/postgres/io/bitstring.hpp) reads the field's bit-length prefix into anInteger(int32) directly from the server buffer, sobit_countis peer-controlled.(bit_count + 7) / 8before comparing against the remaining buffer length. For a value nearINT_MAXthis addition is signed overflow (undefined behavior, reported by the UBSan build), and a negativebit_countpasses the length check and skips the read loop, so a malformed field is silently accepted as an empty bit string instead of being rejected.bit_count < 0up front and perform the ceil-division insize_t, so the value is validated before use and the addition cannot overflow. Parsing of valid lengths is unchanged, and bothbit/bit varyingand theFlags/bitset/arraycontainers route through this parser.Added a non-DB unit test that feeds a negative and an
INT_MAXlength prefix (both now throwInvalidBitStringRepresentation) plus a valid round-trip.