fix core: double truncation in request logging - #1344
Open
rjazhenka1 wants to merge 1 commit into
Open
rjazhenka1 wants to merge 1 commit into
rjazhenka1 wants to merge 1 commit into
Conversation
apolukhin
requested changes
Sep 15, 2026
apolukhin
left a comment
apolukhin
left a comment
Member
There was a problem hiding this comment.
Nice catch! A few comments follow:
| const std::string& request_body | ||
| ) const { | ||
| const size_t limit = GetConfig().request_body_size_log_limit; | ||
| return utils::log::ToLimitedHex(request_body, limit); |
Member
There was a problem hiding this comment.
ToLimitedHex does a good job here. It saves memory
| const std::string& response_data | ||
| ) const { | ||
| const size_t limit = GetConfig().response_data_size_log_limit; | ||
| return utils::log::ToLimitedHex(response_data, limit); |
Member
There was a problem hiding this comment.
ToLimitedHex does a good job here. It saves memory
| ) const { | ||
| const std::size_t limit = GetConfig().response_data_size_log_limit; | ||
| return utils::log::ToLimitedUtf8(response_data, limit); | ||
| return response_data; |
Member
There was a problem hiding this comment.
Please, add tests that catch the initial issue and make sure that id does not appear again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Request and response body logs are truncated twice, which results in
(truncated, total X bytes)message having an incorrect size value (roughly aroundrequest_body_size_log_limit/response_data_size_log_limit).1st truncation happens in
GetRequestBodyForLogging()andGetResponseDataForLogging()(the resulting string is bigger than the limit due to the(truncated...)message).2nd truncation happens in
GetRequestBodyForLoggingChecked()andGetResponseDataForLoggingChecked(). Since the string from the 1st truncation is bigger than the limit, the string is truncated again and incorrect size is shown in the message.Fix:
To fix the problem, I removed the 1st truncation call. This is okay, since request/response bodies are always truncated again in the 2nd call.
Before / after:
To showcase the issue, I used a simple request which consists of the letter "a" repeated for 10 KiB.
Before:
After: