Repository navigation
setup_builder: set http/insecure only on the Docker mirror entry so buildx imagetools create can push Docker Hub manifest lists from the fallback builder - #150
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
… entry The mirror is the only plain-HTTP endpoint. With http = true on the docker.io entry, buildx read the fallback builder's config and sent imagetools create's manifest PUT to Docker Hub over plain HTTP; the 301 to HTTPS turned it into a GET that returned 404. Docker Hub gets BuildKit's defaults: HTTPS with certificate verification. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
ae3d4c8 to
190a168
Compare
buildx imagetools create can push manifest listsbuildx imagetools create can push Docker Hub manifest lists from the fallback builder
|
|


Summary
Let
docker buildx imagetools createpush Docker Hub manifest lists from the fallback builderWhen the action falls back to the local
docker-containerbuilder,docker buildx imagetools create -t docker.io/...fails with404 Not Foundon the manifest PUT. With this PR it pushes over HTTPS. (BLA-5188)remotedriver) builder, which gets no config file from buildx, and BuildKit's own image pushes.Set
httpandinsecureonly on the Blacksmith mirror's registry entryThe mirror is the only plain-HTTP endpoint, so
getDockerMirrorRegistryConfig()puts the two flags only on the mirror's own entry. Docker Hub gets BuildKit's defaults.buildx reads the
docker-containerbuilder's config for its own registry calls.http = trueondocker.iomade it send them tohttp://registry-1.docker.io; Docker Hub answers 301 to HTTPS, and the redirected PUT becomes a body-less GET.BuildKit takes a mirror's scheme and TLS settings from the mirror's own entry, so pulls still go to the mirror over HTTP.
Verify Docker Hub's TLS certificate in the Blacksmith buildkitd
buildkitd.tomlfor the Blacksmith builder comes from the same function, so it changes the same way. On the base branch, buildkitd talks to Docker Hub over HTTPS without certificate verification and retries over plain HTTP on a TLS error. With this PR it uses verified HTTPS only.Checked locally (buildx v0.36.1, buildkit v0.34.2,
docker-containerbuilder)http://registry-1.docker.ioNot checked: the manifest push against Docker Hub with real push credentials.
Link to Devin session: https://app.devin.ai/sessions/a2912f9d80634ddcb92d74203680bb62
Open in Devin Desktop: https://app.devin.ai/desktop/session/a2912f9d80634ddcb92d74203680bb62?variant=devin
Requested by: @piob-io
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need. (Staging)Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.🟢 Devin Review found nothing to fix · View findings