Repository navigation
fix(hermit): pass the gateway as part of ip= - #1198
Merged
cmainas merged 2 commits intoNov 11, 2026
Merged
Conversation
👷 Deploy request for urunc pending review.Visit the deploys page to approve it
|
Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com>
Hermit reads the address and the gateway from one boot argument, ip=<ip>/<prefix>:<gateway>. It does not parse a separate gateway=<gw>, so the guest got no default route and could only answer clients on its own subnet. Fixes: urunc-dev#1197 Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com>
martijnhoekstra
force-pushed
the
fix/hermit-gateway
branch
from
November 10, 2026 16:02
e6ff9b2 to
854ab3b
Compare
Contributor
|
Hello @martijnhoekstra , The PR looks good, let;s mark it ready so we can merge it. |
cmainas
approved these changes
Nov 11, 2026
cmainas
left a comment
cmainas
left a comment
Contributor
There was a problem hiding this comment.
Thank you @martijnhoekstra for the fix.
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 11, 2026
PR: #1198 Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 11, 2026
Hermit reads the address and the gateway from one boot argument, ip=<ip>/<prefix>:<gateway>. It does not parse a separate gateway=<gw>, so the guest got no default route and could only answer clients on its own subnet. PR: #1198 Fixes: #1197 Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot
pushed a commit
that referenced
this pull request
Nov 11, 2026
PR: #1198 Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot Bot
pushed a commit
that referenced
this pull request
Nov 11, 2026
Hermit reads the address and the gateway from one boot argument, ip=<ip>/<prefix>:<gateway>. It does not parse a separate gateway=<gw>, so the guest got no default route and could only answer clients on its own subnet. PR: #1198 Fixes: #1197 Signed-off-by: Martijn <martijn.hoekstra@kiteworks.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hermit reads the gateway as part of
ip=<ip>/<prefix>:<gw>(hermit-os/kernelsrc/env/ip_config.rs). The separategateway=<gw>that urunc writes now is logged as an unparsable boot argument, and the guest gets no default route.This changes
CommandStringto write oneip=argument, and addshermit_rs_test.go: the address with and without a gateway, with application arguments after--, and with only application arguments.Compatibility: Hermit main reads this form since hermit-os/kernel f2f05350. No Hermit version has read
gateway=so far, so nothing is breaking. The latest released version, v0.13.2, (03-13-2026) doesn't take this format though - it takes-ip,-maskand-gateway. This PR changes nothing for that or any other currently released version.Related issues
gateway=is not a Hermit boot argument) #1197How was this tested?
make test_unikernelspasses. On the old code, the two cases with a gateway fail.test_unikontainerspasses as a non-root user; as root,TestCopyFileandTestMoveFilefail, on 8355257 too.make lintuses v2.9, which can't load a go1.27.3 module.go test ./tests/e2e -run TestE2E --ginkgo.focus=Ctr) with urunc built bymake static: 13 of 14 specs pass, includingQemu-hermit-hello-world.Firecracker-unikraft-hellofails with the Unikraft guest'sAssertion failure: ml->flags == mr->flagson Firecracker v1.17.0, the same on 8355257. Skipped because the test machine lacks devmapper, virtiofsd and Hyperlight: the two rumprun specs,Qemu-linux-read-file-virtiofsandHyperlight-unikraft-hello.gateway=is not a Hermit boot argument) #1197: urunc runs-append "ip=10.4.0.3/24:10.4.0.1", the guest logsGateway: 10.4.0.1, and the routed client (192.168.77.1) gets its echo. The on-link client still does.LLM usage
Claude Opus 5.5 (
claude-opus-5-5) helped write the change, the test and this description, and ran the tests above. I reviewed the change and the results.Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).make lint can't run here: its pinned golangci-lint v2.9 doesn't load a go1.27.3 module (on main too). golangci-lint v2.15, the version CI uses, reports no new issues. I filed #1201 -- it's two-liner fix to the makefile