Skip to content

Bump uk-modulus-checking from 0.1.4 to 0.1.5 - #292

Draft
pedropiloto wants to merge 1 commit into
masterfrom
feature/bump-uk-modulus-checking
Draft

Bump uk-modulus-checking from 0.1.4 to 0.1.5#292
pedropiloto wants to merge 1 commit into
masterfrom
feature/bump-uk-modulus-checking

Conversation

@pedropiloto

@pedropiloto pedropiloto commented Aug 11, 2026

Copy link
Copy Markdown

Description

Update Vocalink data sets to v900, valid as of 15/08/2026.

Related issues

https://uphold.atlassian.net/browse/DPAY-5767
uphold/uk-modulus-checking#29

@pedropiloto
pedropiloto requested review from a team as code owners August 11, 2026 12:43
Copilot AI lite review requested due to automatic review settings August 11, 2026 12:43
@pedropiloto
pedropiloto requested review from a team as code owners August 11, 2026 12:43
@pedropiloto
pedropiloto marked this pull request as draft August 11, 2026 12:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the uk-modulus-checking dependency reference in this repo to a newer source revision, ensuring local development/test installs pull the updated package contents.

Changes:

  • Switched uk-modulus-checking in package.json from an npm version to a pinned GitHub commit.
  • Updated yarn.lock to reflect the GitHub tarball resolution for that commit.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Updates the uk-modulus-checking dependency spec to a GitHub commit reference.
yarn.lock Refreshes lock entry to resolve uk-modulus-checking from GitHub tarball (version recorded as 0.1.4).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread package.json
"release-it": "^19.2.3",
"tin-validator": "^1.1.0",
"uk-modulus-checking": "0.0.3",
"uk-modulus-checking": "github:uphold/uk-modulus-checking#6d471ba5d5e8ab136aa0e70ea20321438c611d4d",
Comment thread yarn.lock
version "0.0.3"
resolved "https://registry.npmjs.org/uk-modulus-checking/-/uk-modulus-checking-0.0.3.tgz"
integrity sha1-IyfmwCY2a2jbsySy/sGCsMDeG6k=
"uk-modulus-checking@github:uphold/uk-modulus-checking#6d471ba5d5e8ab136aa0e70ea20321438c611d4d":

@josecarlosbrandao josecarlosbrandao Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick reminder that this must point to yarn registry as opposed to git

Comment thread package.json
"release-it": "^19.2.3",
"tin-validator": "^1.1.0",
"uk-modulus-checking": "0.0.3",
"uk-modulus-checking": "github:uphold/uk-modulus-checking#6d471ba5d5e8ab136aa0e70ea20321438c611d4d",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick reminder that we need to update this with new semver release xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants