Drafts and projects stop reading as one panel with a rule through it - #125
Merged
Merged
Conversation
The projects page shows two collections when a setup was never finished: "Setup in progress" above "Your projects". They are sibling .group panels, and .group carried padding but no vertical margin — so the two sat flush and read as a single panel divided by a border rather than as two things. Adjacent-sibling rather than a margin on every .group: the common case is one collection, and a blanket top margin would have moved that page's spacing against the shell for no reason. The value is .group's own padding clamp, so the space between panels tracks the space inside them across viewports instead of drifting apart at one width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/projectsshows two collections when a setup was never finished — Setup inprogress above Your projects. They are sibling
.grouppanels, and.groupcarriedpaddingbut no verticalmargin, so the two sat flush: onepanel with a rule through it rather than two things.
Two choices worth a second's thought:
.group. The common case is asingle collection — projects with no drafts — and a blanket top margin would
have shifted that page's spacing against the shell for no reason.
.group's own padding, so the gap between panels tracksthe space inside them as the viewport changes, rather than the two drifting
apart at some width.
Verify
Confirmed against the running dev server rather than by reading the source —
/_next/static/css/app/projects/page.cssserves:One CSS rule; no typecheck or test surface touched.