Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an AttributeError in the Python-side Stokes preconditioner fallback check.
_check_velocity_preconditioner() records when the velocity block falls back from the intended multigrid preconditioner, but the Python-side Stokes object did not have _record_pc_fallback(). A normal Stokes solve could therefore fail with:
AttributeError: 'SNES_Stokes' object has no attribute '_record_pc_fallback'
This adds a small Python-side fallback recorder and pc_fallbacks property so the fallback is recorded and the warning path can complete.
This does not change solver setup or preconditioner selection.
Validation:
The units tutorial now completes successfully. The remaining GAMG message is the intended runtime warning, not a crash.