Skip to content

Require exact publication for benchmark handoffs - #4

Open
aamir wants to merge 2 commits into
mainfrom
feature/benchmark-publication-pin
Open

aamir wants to merge 2 commits into
mainfrom
feature/benchmark-publication-pin

Conversation

@aamir

@aamir aamir commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

User impact

Coding agents can read a dashboard benchmark handoff with understudy benchmarks show --expect-publication <id> --include-report --json. The CLI fails clearly if a newer benchmark replaced the one the user copied, instead of silently supplying different evidence.

Root cause

benchmarks show reads the current publication only. A copied dashboard command could therefore return a different benchmark after republishing.

Validation

  • Focused synthetic command and service tests pass, including changed and missing publications.
  • All 695 tracked CLI tests pass.
  • Public package boundary check passes.

This is the CLI half of understudy-platform#1031.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T16:12:10.368105Z eef3c84 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eef3c84f08

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/benchmarks/service.ts Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant