Repository navigation
Include session and turn IDs in CLI setup - #1
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07466694a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application setup currently explains workload attribution and response request-ID storage but does not establish which model calls belong to one session or logical turn. Workload creation also omits the request-header recipe, so setup can leave related calls ungrouped.
workloads create, including an additiveintegrationobject in JSON output. These remain application-supplied request headers, not workload creation fields.setup-understudy, with a shared SDK reference covering retries, continuations, resumed jobs, concurrency, ID constraints, and per-request header examples.Validation:
npm run checkpassed (685 tests, build, public tracked/packed-content check);git diff --checkpassed. No live inference or release publication.The header contract was checked against the current gateway implementation: it parses both IDs, carries them into event/export metadata, and passes session ID to experiment selection. This is source verification, not a claim about deployed capture persistence; the setup guide explicitly distinguishes local header checks from hosted verification.
Final validation: CI passed on
7491f09, including all source checks, the macOS arm64 build, and standalone execution with Node and Bun absent from PATH. The accepted review finding about the standalone binary's expected skill-file list is fixed in that commit; the review thread is resolved. The 13 focused bundle/distribution tests also passed locally.