fix: await dispatcher cleanup in arun_many streams - #2136
Open
nightcityblade wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
CI note: the only failing check is the repository's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2083.
Make the public
AsyncWebCrawler.arun_many(..., stream=True)wrapper explicitly own and close the dispatcher stream. Closing the public stream now completes dispatcher cleanup before proxy-session release and beforeaclose()returns.List of files changed and why
crawl4ai/async_webcrawler.py- close the inner dispatcher async generator withcontextlib.aclosing().tests/async/test_arun_many_stream_cleanup.py- verify that closing the public wrapper synchronously closes its dispatcher stream.How Has This Been Tested?
.venv/bin/python -m pytest tests/async/test_arun_many_stream_cleanup.py tests/async/test_dispatchers.py::TestDispatchStrategies::test_memory_adaptive_stream_closure_cleans_up_tasks -q- 2 passed..venv/bin/ruff check --isolated --select E9,F63,F7,F82 --ignore F821 crawl4ai/async_webcrawler.py tests/async/test_arun_many_stream_cleanup.py- passed..venv/bin/black --check --target-version py312 --fast tests/async/test_arun_many_stream_cleanup.py- passed..venv/bin/python -m compileall -q crawl4ai/async_webcrawler.py tests/async/test_arun_many_stream_cleanup.py- passed.git diff --check upstream/develop...HEAD- passed.The full legacy
tests/async/test_dispatchers.pymodule produced 10 passes and one unrelated pre-existing failure:test_monitor_integrationstill passes removedCrawlerMonitor(max_visible_rows=..., display_mode=...)arguments.Checklist:
aclosing().