fix(orchestrator): make treehash-mapping cache write best-effort (audit #8) - #249
Draft
sbalabanov wants to merge 1 commit into
Draft
fix(orchestrator): make treehash-mapping cache write best-effort (audit #8)#249sbalabanov wants to merge 1 commit into
sbalabanov wants to merge 1 commit into
Conversation
The treehash-mapping Put maps (remote, base sha, requests) to treehash so future requests can skip workspace materialization. Unlike the graph blob write (which is load-bearing because the response is read back from storage), this is a pure cache optimization whose failure should not fail the entire request after a successful computation. On error, log a structured warning and continue serving the computed result. Add inline comment documenting the two-tier cache write policy and table-driven tests pinning both behaviors. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
xytan0056
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The treehash-mapping
Putis a pure cache optimization (maps build description to treehash to skip workspace materialization on future requests), but its failure was incorrectly failing the entire request after a successful graph computation.Putbest-effort: on error, log a structured warning and continue serving the computed result🤖 Generated with Claude Code