Skip to content

test: assert Value.Store(nil) panics in value_test.go - #211

Merged
justinhwang merged 2 commits into
uber-go:masterfrom
aoright:test/value-store-nil-panic
Sep 17, 2026
Merged

justinhwang merged 2 commits into
uber-go:masterfrom
aoright:test/value-store-nil-panic

Conversation

@aoright

@aoright aoright commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add test assertion in value_test.go verifying that Value.Store(nil) panics according to the sync/atomic.Value specification.

Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
@CLAassistant

CLAassistant commented Aug 19, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (703f34c) to head (1a5e4df).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #211   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          438       402   -36     
=========================================
- Hits           438       402   -36     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread value_test.go Outdated
@justinhwang
justinhwang merged commit c8c4698 into uber-go:master Sep 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants