Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Datepicker flickering when the input is wrapped by
.form-adorn.Motivation & Context
When a Datepicker input is wrapped in
.form-adorn, clicking the input can cause the calendar to briefly hide and reopen, resulting in a visible flicker.The Datepicker uses the
.form-adornwrapper as its positioning element, while Vanilla Calendar Pro's document-level click handler treats the input as outside the calendar because it expects the clicked element to match its configured input element.This change prevents clicks within the Datepicker's positioning element from triggering outside dismissal and removes the conflicting capture-phase click handler when the positioning element differs from the input.
Regression tests were added for input clicks, clicks inside the
.form-adornwrapper, and clicks outside the wrapper.Type of changes
Checklist
Live previews
Related issues
Fixes #43101