Repository navigation
Conversation
…tention readers
Slice 3 of flags-stage2-plan.md. flagReader{reg} replaces the free
functions that read featureflags.Current() via FeatureFlagDefault; a nil
registry still falls back to Current(). Attention flags resolve through
the composition root's registry and one shared options source.
Contributor
CI memory (Go affected-package tests)2 benchmarks (no base to compare with)
|
| Benchmark | Value | Range |
|---|---|---|
peak_used [max] |
4117 MB |
— |
min_available [min] |
11864 MB |
— |
Environment
| Head | |
|---|---|
sha |
13ec0bd966d02d79e8b927138915da5793bc7271 |
Head-only report: add a base to see changes.
Contributor
|
Selective e2e (shadow, non-blocking): 0 of 0 targets selected; shard jobs: skipped. The full suite in build.yml stays authoritative. |
…ading with tests Wiring paths use the service's injected registry (nil when none) so a service built without SetCurrent no longer panics at construction; the nil case falls back to Current() at read time. FeatureFlagService.injected is nil-receiver safe. One test per constructor site proves the injected registry is threaded.
Contributor
📊 Feature E2E CoverageFeature E2E coverage: 57/351 tested (16%)
|
Contributor
|
Selective e2e (shadow, non-blocking): 0 of 0 targets selected; shard jobs: skipped. The full suite in build.yml stays authoritative. |
…istry Tests drive WireNotificationActions, wireGuidanceMirror and BuildServiceDeps with a flipped-default registry; nil at any of those call sites now fails. Adds SessionService.GuidanceMirror as the read accessor. The plan notes the remaining eager wireNotificationActionFlags fallback.
Contributor
|
Selective e2e (shadow, non-blocking): 0 of 0 targets selected; shard jobs: skipped. The full suite in build.yml stays authoritative. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 3 of
project_plans/package-split-ocp/flags-stage2-plan.md(slices 1 #1709, 2 #1711 merged). No behaviour change.flagReader{reg}replaces the free functions that readfeatureflags.Current()throughFeatureFlagDefault(effectiveFlag,resolveEffectiveFlag,resolveStage,scoped,dispatcherRunning,resolveAnswerQuestion). A nil registry still falls back toCurrent()until slice 7.wireNotificationActionFlagsseeds from the service's registry.ResolveAttentionFlags/LoadAttentionFlags,NewDescriptorBuilder,NewGuidanceHookMirrorandNewNotificationActionDispatchertake a trailing registry; production passesSessionService.FeatureFlagRegistry().liveAttentionFlagsglobal is gone:newAttentionOptionsSource(core.FlagRegistry)builds one cached source, shared by the review-queue poller and startup scanner throughServiceDeps.AttentionOptions.Tests:
feature_flags_reader_injected_registry_test.gouses a registry with flipped defaults and asserts the injected one is consulted; reverting any reader toCurrent()fails all three tests.