Repository navigation
fix(llm-sync): don't copy marketplace plugins' hooks into Claude's settings.json - #67
Merged
Merged
Conversation
…ttings.json
Claude Code loads /plugin install'd plugins' hooks itself with
${CLAUDE_PLUGIN_ROOT} set. llm-sync also merged them into settings.json,
duplicating them and running them with the variable unset (the
claude-magic-compact UserPromptSubmit hook ran 'bun /src/hook.ts').
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Code loads
/plugin install'd plugins' hooks natively, with${CLAUDE_PLUGIN_ROOT}set. llm-sync's Claude target also merged them into~/.claude/settings.json, duplicating each hook and running the copy with the variable unset. The claude-magic-compactUserPromptSubmithook becamebun ${CLAUDE_PLUGIN_ROOT}/src/hook.tsand would runbun /src/hook.ts.Plugins now carry
from_marketplace, andClaudePluginInstaller._install_hooksskips those. Gemini and Antigravity targets are unchanged. Dotfiles-committed plugins such as core-hooks still install. Tests: 8 pass under pytest (two new).Config/tooling-only change. A stale entry already written to settings.json must be removed by hand; this does not clean it up.
🤖 Generated with Claude Code