Skip to content

allow slim to be built from source - #52

Merged
jeromekelleher merged 3 commits into
tskit-dev:mainfrom
petrelharp:devslim
Aug 14, 2026
Merged

allow slim to be built from source#52
jeromekelleher merged 3 commits into
tskit-dev:mainfrom
petrelharp:devslim

Conversation

@petrelharp

Copy link
Copy Markdown
Contributor

For instance, I'm currently working on pyslim, which needs to use the current in-development multitrait branch of SLiM.

@petrelharp

Copy link
Copy Markdown
Contributor Author

Fuck it, we'll just not build docs with development SLiM and check docs locally.
Screenshot From 2026-08-05 09-21-16

@petrelharp petrelharp closed this Aug 5, 2026
@jeromekelleher

Copy link
Copy Markdown
Member

Just FYI, to fix this issue with zizmor you put the inputs into a local environment variable like this:

The reason for this (a good one) is that it's stops arbitrary shell interpolation within your inputs (so letting an attacker run abitrary shell commands in your session).

@petrelharp

Copy link
Copy Markdown
Contributor Author

okay maybe I do need this...

@petrelharp petrelharp reopened this Aug 13, 2026
@petrelharp

Copy link
Copy Markdown
Contributor Author

Testing this out (I think) over at tskit-dev/pyslim#431

@petrelharp

Copy link
Copy Markdown
Contributor Author

Hey! It works! To test it I had to switch the action link to this branch; I'll switch it back now. So I think we can merge this, and I can test it again with @main.
Screenshot From 2026-08-13 21-10-06

@petrelharp

Copy link
Copy Markdown
Contributor Author

Wait I spoke too soon...
Screenshot From 2026-08-13 21-13-10

@petrelharp

Copy link
Copy Markdown
Contributor Author

NOW it works (with some later, expected, errors because I deleted most of the docs files in that test branch).
Screenshot From 2026-08-13 21-23-09

@petrelharp

Copy link
Copy Markdown
Contributor Author

Well, zizmor initially complained about the fix for #53, but updating zizmor fixed that problem.

@petrelharp

Copy link
Copy Markdown
Contributor Author

Okay, I think this can be merged.

@petrelharp

Copy link
Copy Markdown
Contributor Author

and OKAY I got a successful build over at https://github.com/tskit-dev/pyslim/actions/runs/31771028178/job/94676838469?pr=431 with this

@jeromekelleher
jeromekelleher merged commit 28a9c58 into tskit-dev:main Aug 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants