feat: migrate Radio Wave to Manifest V3 - #55
Open
tryasko wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Migrates Radio Wave to Manifest V3 with offscreen audio playback and a redesigned popup.
Changes:
- Adds an MV3 service worker and offscreen player.
- Introduces crossfading, Media Session controls, and playback synchronization.
- Moves station data to JSON and modernizes the popup UI.
Reviewed changes
Copilot reviewed 10 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
shared/stations.json |
Adds centralized station data. |
shared/stations.js |
Removes the legacy global station list. |
README.md |
Updates version and station-list link. |
popup/index.html |
Redesigns the popup interface. |
popup/application.js |
Adds message-based playback controls. |
manifest.json |
Migrates the extension to MV3. |
background/updater.js |
Exports state initialization for modules. |
background/service-worker.js |
Routes commands and manages the offscreen document. |
background/player.js |
Implements crossfading and Media Session support. |
background/index.html |
Loads the player as a module. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| import stationList from "../shared/stations.json" with { type: "json" }; | ||
|
|
||
| const currentVersion = "2.2.9"; |
| command: "status" | ||
| }); | ||
|
|
||
| if (!status?.ok || status.playing) { |
Comment on lines
+356
to
+366
| body[data-playback="played"] .waveform span, | ||
| body[data-playback="played"] .mini-wave span { | ||
| animation-duration: 1200ms !important; | ||
| animation-iteration-count: infinite !important; | ||
| } | ||
|
|
||
| body[data-playback="paused"] .waveform span, | ||
| body[data-playback="switching"] .waveform span { | ||
| animation-duration: 1600ms !important; | ||
| animation-iteration-count: infinite !important; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.