Skip to content

fix(deps): bump x/net, x/crypto and grpc for CVEs - #18

Merged
malfattiftrm merged 2 commits into
mainfrom
malfattift/go-dep-cves
Nov 12, 2026
Merged

malfattiftrm merged 2 commits into
mainfrom
malfattift/go-dep-cves

Conversation

@malfattiftrm

@malfattiftrm malfattiftrm commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

What

Bumps three Go modules flagged by Wiz and Dependabot:

Module Before After
golang.org/x/net 0.57.0 0.60.0 (1 critical, 2 high)
golang.org/x/crypto 0.55.0 0.57.0 (2 high; Wiz asked for 0.56.0, but x/net 0.60.0 requires 0.57.0)
google.golang.org/grpc 1.79.3 1.83.1 (GHSA-hrxh-6v49-42gf, GHSA-2v4p-qf9q-27wj, GHSA-vp52-pcj8-j9qc, GHSA-qc2q-p7wx-3px3)

Why

These are the open critical and high findings on this repo. All three modules are indirect dependencies, pulled in through cloud.google.com/go/storage.

How

Ran go get for the three modules, then go mod tidy. grpc 1.83 requires newer versions of other modules, so this also upgrades:

  • cloud.google.com/go/storage 1.43.0 → 1.56.0
  • OpenTelemetry 1.41 → 1.44
  • google.golang.org/api and genproto

It also raises the go directive from 1.25.0 to 1.26.0. The Dockerfile already builds with golang:1.26.10, and CI reads the Go version from go.mod. Besides go.mod and go.sum, the PR changes the CI lint version and makes the small lint fixes listed under Testing.

Testing

  • make test passes (142 passed, 0 failed)
  • make lint passes. CI moves from golangci-lint v2.4.0 to v2.15.0, because v2.4.0 is built with Go 1.25 and refuses a go.mod targeting 1.26. v2.15.0 reported five issues, fixed here: net.JoinHostPort for the dial addresses in main.go and pg_main.go, and fmt.Fprintf instead of WriteString(fmt.Sprintf(...)) in one test.
  • go build ./... passes
  • Tested locally with Docker Compose (if applicable)
  • Updated documentation (if applicable)

golang.org/x/net 0.57.0 -> 0.60.0, golang.org/x/crypto 0.55.0 -> 0.57.0,
google.golang.org/grpc 1.79.3 -> 1.83.1. grpc 1.83 pulls newer
cloud.google.com/go/storage, OpenTelemetry and genproto modules and raises
the go directive to 1.26.0 (the Dockerfile builds with golang:1.26.10).

Co-Authored-By: TRM Agent <noreply@trmlabs.com>
@malfattiftrm
malfattiftrm requested a review from a team as a code owner November 12, 2026 17:34
v2.4.0 is built with Go 1.25 and refuses a go.mod targeting 1.26.0.
v2.15.0 adds govet hostport and staticcheck QF1012 findings, fixed here:
net.JoinHostPort for the proxy dial addresses (IPv6-safe) and
fmt.Fprintf into the strings.Builder in a test.

Co-Authored-By: TRM Agent <noreply@trmlabs.com>
@malfattiftrm
malfattiftrm merged commit d2ebc83 into main Nov 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants