Repository navigation
security: bump Go builder image to 1.26.10 — eMudhra CA compromise - #17
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Force merging because of ##inc-2026-10-20-emudhra-ca-key-compromise-coordinate-trust-store-patching |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the Docker builder image from
golang:1.24-alpinetogolang:1.26.10-alpine.Dockerfilegolang:1.24-alpinegolang:1.26.10-alpineWhy
Private keys for 8 eMudhra intermediate CA certificates were compromised (https://emudhra.we-have-a-problem.com).
1.26.10(1.26 line)Go 1.24 is out of support and gets no patch release, so the builder moves to the patched 1.26 line.
How
Only the builder image changes.
go.modkeepsgo 1.24.0(notoolchaindirective), so the build does not require the newer language version.Note: the CI and release workflows use
setup-gowithgo-version-file: go.mod, somake test, lint and the CI build matrix still run on Go 1.24.0. The released artifact is the multi-arch image built fromDockerfile, and that now uses 1.26.10. Moving CI onto a patched toolchain would mean adding atoolchain go1.26.10directive togo.mod, which this PR leaves out on purpose.Testing
Run locally with
GOTOOLCHAIN=localand the go1.26.10 toolchain:go build ./...✅go test -race -short ./...✅ (ok github.com/trmlabs/doppel)go vet ./...fails on existing code with Go 1.26's vet. Thehostportanalyzer, added in Go 1.25, flagsfmt.Sprintf("%s:%s", …)addresses passed tonet.Dial:net.JoinHostPortin a follow-up, or here if preferred.make lintnot run (golangci-lint is not installed locally)docker buildnot run (no Docker daemon).golang:1.26.10-alpineexists on Docker Hub.Follow-up
The
ghcr.io/trmlabs/doppelimage must be rebuilt (cut a new release tag) and redeployed to pick this up.