Skip to content

security: bump Go builder image to 1.26.10 — eMudhra CA compromise - #17

Merged
carjessu-trm merged 1 commit into
mainfrom
security/emudhra-ca-patch
Oct 20, 2026
Merged

carjessu-trm merged 1 commit into
mainfrom
security/emudhra-ca-patch

Conversation

@carjessu-trm

Copy link
Copy Markdown
Contributor

What

Bumps the Docker builder image from golang:1.24-alpine to golang:1.26.10-alpine.

File Old New
Dockerfile golang:1.24-alpine golang:1.26.10-alpine

Why

Private keys for 8 eMudhra intermediate CA certificates were compromised (https://emudhra.we-have-a-problem.com).

Software Patched version
Go 1.26.10 (1.26 line)

Go 1.24 is out of support and gets no patch release, so the builder moves to the patched 1.26 line.

How

Only the builder image changes. go.mod keeps go 1.24.0 (no toolchain directive), so the build does not require the newer language version.

Note: the CI and release workflows use setup-go with go-version-file: go.mod, so make test, lint and the CI build matrix still run on Go 1.24.0. The released artifact is the multi-arch image built from Dockerfile, and that now uses 1.26.10. Moving CI onto a patched toolchain would mean adding a toolchain go1.26.10 directive to go.mod, which this PR leaves out on purpose.

Testing

Run locally with GOTOOLCHAIN=local and the go1.26.10 toolchain:

  • go build ./... ✅
  • go test -race -short ./... ✅ (ok github.com/trmlabs/doppel)
  • ⚠️ go vet ./... fails on existing code with Go 1.26's vet. The hostport analyzer, added in Go 1.25, flags fmt.Sprintf("%s:%s", …) addresses passed to net.Dial:
    main.go:69:29: address format "%s:%s" does not work with IPv6 (passed to net.Dial at L79)
    main.go:70:28: address format "%s:%s" does not work with IPv6 (passed to net.Dial at L92)
    pg_main.go:57:29: address format "%s:%s" does not work with IPv6 (passed to net.Dial at L74)
    
    This is a lint finding, not a build break. The image build doesn't run vet, and CI still vets with 1.24. Fix with net.JoinHostPort in a follow-up, or here if preferred.
  • make lint not run (golangci-lint is not installed locally)
  • docker build not run (no Docker daemon). golang:1.26.10-alpine exists on Docker Hub.

Follow-up

The ghcr.io/trmlabs/doppel image must be rebuilt (cut a new release tag) and redeployed to pick this up.

Co-authored-by: Cursor <cursoragent@cursor.com>
@carjessu-trm
carjessu-trm requested a review from a team as a code owner October 20, 2026 21:05
@carjessu-trm

Copy link
Copy Markdown
Contributor Author

Force merging because of ##inc-2026-10-20-emudhra-ca-key-compromise-coordinate-trust-store-patching

@carjessu-trm
carjessu-trm merged commit a8917fe into main Oct 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant