Skip to content

Drop the codeclimate-test-reporter development dependency - #684

Merged
tricknotes merged 1 commit into
mainfrom
drop-codeclimate-test-reporter
Sep 12, 2026
Merged

Drop the codeclimate-test-reporter development dependency#684
tricknotes merged 1 commit into
mainfrom
drop-codeclimate-test-reporter

Conversation

@tricknotes

@tricknotes tricknotes commented Sep 12, 2026

Copy link
Copy Markdown
Owner

spec/spec_helper.rb has started a Code Climate test reporter on every run since 2015. It has never reported anything.

It is a no-op here

CodeClimate::TestReporter.start starts SimpleCov only when the reporter decides to run, and that decision needs an environment variable:

def self.run?
  environment_variable_set? && run_on_current_branch?
end

def self.environment_variable_set?
  @environment_variable_set = !!ENV["CODECLIMATE_REPO_TOKEN"]
  ...
end

Nothing in this repository sets CODECLIMATE_REPO_TOKEN — not .github/workflows/tests.yml, not bin/setup, not the Rakefile. There is no .codeclimate.yml and no badge in the README. Running the two lines from spec_helper.rb as they stand:

run? = false
CODECLIMATE_REPO_TOKEN set? = false
SimpleCov.running = false

So SimpleCov never starts, no coverage is measured, and nothing is uploaded. The /coverage/ entry in .gitignore has been guarding a directory that is never written.

It is deprecated upstream

  • codeclimate/ruby-test-reporter was archived on 2025-07-19. Its README: "These configuration instructions refer to a language-specific test reporter who is now deprecated in favor of our new unified test reporter client."
  • The gem's last release is 1.0.9, from 2018-10-08. The gemspec pinned ~> 0.6.0, older still.
  • Code Climate Quality has been succeeded by Qlty, and its migration guide states the old test reporter is not supported there. Adopting coverage reporting again would mean a new client and a new service, not a version bump.

Changes

  • spec/spec_helper.rb: drop the require and the start call
  • ember-cli-rails.gemspec: drop the development dependency

No CHANGELOG.md entry: this is a development dependency and nothing an application using the gem can observe changes.

Gemfile.lock is not committed, so there is nothing to regenerate here. Locally the removal also drops simplecov, simplecov-html and simplecov_json_formatter from the development bundle.

Tests

bin/rspec spec/lib gives the same result before and after: 174 examples, 2 failures. Both failures (app_spec.rb:192, app_spec.rb:200) are present on main and need node_modules installed to find the ember binary.

`CodeClimate::TestReporter.start` only starts SimpleCov when
`CODECLIMATE_REPO_TOKEN` is set. Nothing in this repository sets it, so
the call has been a no-op: no coverage was measured and nothing was
reported.

The gem is also deprecated upstream. codeclimate/ruby-test-reporter was
archived on 2025-07-19 and its README points at the unified test
reporter; its last release, 1.0.9, is from 2018, and the gemspec pinned
`~> 0.6.0`, older still.

Removing it also drops simplecov, simplecov-html and
simplecov_json_formatter from the development bundle.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@tricknotes
tricknotes force-pushed the drop-codeclimate-test-reporter branch from 35e8574 to 4e51aaf Compare September 12, 2026 02:58
@tricknotes
tricknotes marked this pull request as ready for review September 12, 2026 03:00
@tricknotes
tricknotes merged commit 9e47724 into main Sep 12, 2026
16 checks passed
@tricknotes
tricknotes deleted the drop-codeclimate-test-reporter branch September 12, 2026 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants