Repository navigation
Conversation
Fold the never-tagged 1.1.0 section and [Unreleased] into [2.0.0], and bump pyproject.toml and __version__. A major version because the Cell type, bind_row's no-clear binding and skip_validate=False break existing callers, as protowire-cpp v2.0.0 folded its untagged 1.2.1.
Collaborator
Author
|
CI on head ae70aba passed all 18 checks. That covers tests on Linux, macOS and Windows for Python 3.10–3.13, the cibuildwheel smoke builds on all three systems, and CodeQL for C++ and Python. Ready to merge. After the merge, the next steps are the annotated tag |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the 2.0.0 release. Once this merges, tagging
v2.0.0on main runs publish.yml, which publishes to PyPI.pyproject.tomlandprotowire.__version__go from 1.1.0 to 2.0.0.CHANGELOG.md:[Unreleased]and the 1.1.0 section, which was never tagged, become one[2.0.0] — 2026-11-08section. The section opens by saying why it is a major release. The two### Addedlists under Unreleased are merged. protowire-cpp did the same in v2.0.0 with its untagged 1.2.1.Why 2.0.0. Three changes break existing callers:
Cellgains list and block kinds and keeps precision suffixes, sofloat(cell[1])raises on1.5p80(Dataset cells lose list/block values and precision suffixes, so bind_row on them differs from scan #47).bind_rowandscanno longer clear the message before binding (pxf.bind_row promises (pxf.default) and (pxf.required) but applies neither #24).skip_validatedefaults toFalsethere (pxf.bind_row promises (pxf.default) and (pxf.required) but applies neither #24).The owner chose 2.0.0 on 2026-11-08.
Checked. I sorted the old and new changelog lines and diffed them. Every line is kept. The only changes are the new intro, one blank line, and the 1.1.0 entry "Built against protowire-cpp v1.2.0 in CI and the wheels", which now reads "(#23), on the way to v2.1.0". The release builds against v2.1.0, so the old wording was no longer true.
git grepfinds no other1.1.0version string.Main's CI at b779fbd passed all 15 jobs, including the cibuildwheel smoke builds on Linux, macOS and Windows. This PR's own CI is pending.