Repository navigation
docs: drop changelog caveats that later entries fixed - #54
Merged
Merged
Conversation
Four lines of the Unreleased section said what the entries after them undo: - check_decode --limit: "pb rows take none", but --format pb now takes every limit but MaxBytesLiteralLength, through protowire.pb (#53). - DatasetReader: rows parsed under the default max_bytes_literal_length "until protowire-cpp#160 is fixed". Fixed lists that fix. - the decoded message "stops at 100 levels" (#40), and a document with a literal at the depth limit "fails in upb" (#40). #51 fixed #40. - "the 16 that skip Python today": protowire#591 ran them. Measured for the new --limit wording: a limit pb has no setting for exits 2, and the same row under MaxMessageSize=1024 rejects with exit 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unreleased changelog contradicts itself in four places. Each time an older entry carries a caveat that a later PR fixed, and the fix has its own entry further down:
check_decode --limitsaid PB rows take no limits and exit 2. Since pb: a PB codec for dataclasses, ported from protowire-go's encoding/pb #53,--format pbgoes throughprotowire.pband takes every limit butMaxBytesLiteralLength.DatasetReadersaid rows are parsed under the defaultmax_bytes_literal_length"until protowire-cpp#160 is fixed". The Fixed section lists that fix.protowire.pbentry spoke of "the 16 that skip Python today". corpus: run python on the pb rows protowire#591 has since run them.Changes only
CHANGELOG.md. Follows #36 (closed): these are the stale lines its limits work left behind.Evidence
The new
--limitwording ("a limit the row's format has no setting for exits 2") was checked onpb/oversize-2kib.binpb:--limit MaxBytesLiteralLength=10→--limit MaxBytesLiteralLength is not supported for pb, exit 2.--limit MaxMessageSize=1024→reject: pb: input of 2051 bytes exceeds MaxMessageSize=1024, exit 1.The other claims were read from the merged state: #40 and protowire-cpp#160 are closed, and protowire's main manifest has no row that skips
python.