Repository navigation
ci: put vcpkg's protoc on PATH for the Windows test legs - #44
Merged
Merged
Conversation
Every test that compiles a schema skipped on Windows with "protoc not available": 67 of 152 on main. vcpkg installs protoc under tools\protobuf, and only bin was on PATH. Fixes #43
Collaborator
Author
|
CI on head 0643f98 (main with #42 merged in): 18 of 18 checks SUCCESS, run 42285351101. All four Windows test legs (py3.10–3.13) now read The 5 skips that remain are the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43.
On main, every Windows leg skips 67 tests (
85 passed, 67 skippedon windows-latest / py3.13, run 42274927719), all forprotoc not availableexcept the SBE view tests. vcpkg's protobuf includes protoc atinstalled\x64-windows\tools\protobuf\protoc.exe(the build step's CMake reports finding it there), but the pytest step only putbinon PATH.This adds
tools\protobufto PATH in thepytest (Windows)step. Nothing else changes.Evidence
Only Windows CI can show this. I'll post the Windows legs' pass/skip counts here when the run finishes. Expected: the skips drop to the 5 SBE view tests that Linux skips too. Any other skip, or a failure in a test that has never run on Windows before, gets reported here as it is.