Repository navigation
check-decode-android: exit 2 on a missing --schema - #178
Merged
Merged
Conversation
Map.of refuses a null key, so the lookup threw, and the uncaught NPE exited 1, the harness's reject code (#177).
Collaborator
Author
|
CI passed on 36520da, the PR head read back from the remote: Build + Test, Conformance (Go reference), Analyze and CodeQL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177
Without
--schema,check-decode-androidcrashed with a NullPointerException and exited 1. Exit 1 is the harness's "rejected" code, so a reject row run without a schema would have passed. The lookup now skips a null schema, so the existing "need --format, --input and a known --schema" check catches it and exits 2.Evidence, from the built harness:
ImmutableCollections$MapN.probe.check-decode-android: need --format, --input and a known --schema, got null, exit 2.--format sbe --input xgives the same../gradlew :check-decode-android:buildpasses.The fix is one line. #171 and #175 edit other parts of this file.