[bfrancojr]

Convert.xmlToProto now reads a char type's characterEncoding. A char in an encoding that isn't UTF-8 compatible becomes bytes, not string.

Before, every char became a string. So a schema declaring ISO-8859-1 imported cleanly, and the first byte outside UTF-8 then failed the whole message.

Fixes #173

What changes

• A char becomes a string only when its encoding is absent (the FIX SBE default, US-ASCII) or names US-ASCII or UTF-8. Names are matched against the IANA names and aliases, ignoring case and punctuation. This is draft -01 § Character Encoding (SBE: declare a character encoding for text fields protowire#494).
• Any other encoding becomes bytes with the same (sbe.length), plus a comment line that says why. This also applies inside a composite.
• The list of names and the comment wording follow protowire-go#248. That PR is still open, so the two ports will match once it merges.

Evidence

• ./gradlew build at a577c01: 673 tests, 0 failures, 5 skipped (pb: null and zero big numbers in Pb.marshal differ from protowire-go, and a null list element throws #159's, enabled by pb: write null and zero big numbers as protowire-go does, and a BigFloat normalised #170).
• New CharacterEncodingTest (18 tests) uses the schema of Go's TestXMLToProtoCharacterEncoding.
  • It checks the same seven lines Go's test checks: absent, ASCII, US-ASCII and utf_8 give string; ISO-8859-1, and windows-1252 inside a composite, give bytes.
  • Done-when "the generated proto compiles": the importer's output is checked in as sbe/src/test/proto/charenc/enc.proto, so the build compiles it. A test asserts the file is the importer's output byte for byte.
  • A Latin-1 café (63 61 66 E9) round-trips through Codec in the bytes field.

Classification: reversible by a revert. It changes generated schema output for non-UTF-8 chars only, as the draft requires. Measured.

The only overlap with #171, which also touches sbe, is the CHANGELOG.

[bfrancojr]

CI passed on a577c01, the PR head read back from the remote: Build + Test, Conformance (Go reference), Analyze and CodeQL.

[bfrancojr]

I rebased onto main 35d1341. The only conflict was the CHANGELOG, and both entries are kept. The new head is 3980686, read back from the remote. ./gradlew build at the pinned plugin: 735 tests, 0 failures, 0 skipped.