Repository navigation
release: cut v2.1.0 - #175
Merged
Merged
Conversation
This was referenced Nov 7, 2026
Bumps the CMake project version to 2.1.0 and cuts the 2.1.0 changelog section from Unreleased: the DatasetReader streaming work (#160, #161, #164, #166, #168, #169, #171) and keeping a comment that no entry follows (#176). Minor, because it adds the public Lexer(input, start) constructor (#161) and four public AST fields (#176).
trendvidia
force-pushed
the
release-v2.1.0
branch
from
November 7, 2026 11:46
e3e8962 to
03283fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
CMakeLists.txtto 2.1.0 and cuts the## [2.1.0] — 2026-11-07changelog section, as CONTRIBUTING's Releases section says. Rebuilt on main e874165, so it includes #176 (PR #177).pxf::Lexer(std::string_view, Position)(DatasetReader: a row's parse error gives a position within the row, not the stream as protowire-go does #161), andtrailing_commentsonDocument,BlockandBlockValplusleading_commentsonDatasetRow(pxf: keep a comment that no entry follows, as protowire-go#283 does (TrailingComments, DatasetRow.LeadingComments) #176). The rest are fixes that bringDatasetReaderand comment handling in line with protowire-go (DatasetReader ignores UnmarshalOptions::max_bytes_literal_length when it parses a row #160, DatasetReader: a row's parse error gives a position within the row, not the stream as protowire-go does #161, DatasetReader: a cut-off row ends the stream silently, and its limits differ from protowire-go's #164, DatasetReader::Scan honours options protowire-go's Scan drops (skip_validate, skip_post_decode, discard_unknown, on_secret_field, validator) #166, DatasetReader re-lexes a long token from its start on every read #168, pxf: a timestamp right before a row's ')' is refused: the lexer reads the ')' into it #169, DatasetReader holds back a complete row on a live stream #171, pxf: keep a comment that no entry follows, as protowire-go#283 does (TrailingComments, DatasetRow.LeadingComments) #176).### Fixed, plus two### Addedlines and a short summary paragraph. The DatasetReader::Scan honours options protowire-go's Scan drops (skip_validate, skip_post_decode, discard_unknown, on_secret_field, validator) #166 entry now says protowire-go has changed (protowire-go#281 merged), where it said it was changing.PACKAGE_VERSION "2.1.0". ctest passes 747 of 747 locally.scripts/go_differential.shreportsno differencesagainst protowire-go main ca79f5c (v1.17.0) and spec dd8e221. CI on 03283fe (head): all 11 checks pass, including the differential against protowire-go, CodeQL, clang-tidy 18, ASan + UBSan and Windows.After merge: an annotated tag
v2.1.0on the merge commit, thengh release create v2.1.0with the section as its notes.