Repository navigation
pxf: a timestamp ends at ')', as protowire-go's lexer ends it (#169) - #170
Merged
Merged
Conversation
trendvidia
force-pushed
the
timestamp-rparen
branch
from
November 7, 2026 04:22
6ab7ea7 to
2cd0e40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #169.
A
@datasetrow whose last cell is a timestamp, with no space before the), was refused:(2024-01-02T03:04:05Z)gave2:2: invalid timestamp: 2024-01-02T03:04:05Z).Lexer::LexTimestampran the timestamp to a space, newline, tab, CR,,,],},#or a comment opener, and read the)into it. protowire-go'sendsRunalso stops at). The fix adds)to cpp's set, so the two lists now match byte for byte.Evidence
Parseaccepts(2024-01-02T03:04:05Z). cpp main refused it, and accepted(2024-01-02T03:04:05Z, 1)andts = [2024-01-02T03:04:05Z]. Both measured.DatasetTimestampCell.EndsAtTheRowsParenparses the row throughParseand throughDatasetReader, and checks that the cell is a timestamp with the right text. It fails withsrc/stashed and passes with the fix.ctest730/730 locally (macOS). clang-format 18 clean.Found while porting Go's
mayEndTokenfor #168, which usesendsRun. Independent of #167.