Skip to content

refactor: organize permanent tests and enforce tier policy (#325) - #326

Merged
adrianwebb merged 9 commits into
cordisfrom
feature/325-test-organization
Oct 27, 2026
Merged

adrianwebb merged 9 commits into
cordisfrom
feature/325-test-organization

Conversation

@adrianwebb

@adrianwebb adrianwebb commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Outcome

Organize permanent CLI tests into acceptance, regression, integration and unit tiers, preserving the built executable behavior while enforcing permanent layout and complete discovery.

Work authority

  • Work item / Issue: Part of Organize permanent tests by tier and enforce shared testing policy #325; portfolio Organize permanent tests by tier and enforce shared testing policy platform#768.
  • Proposal / decision: Maintainer-directed test cleanup before Task 3D; design. Explicit maintainer approval permits one atomic PR per repository as a scoped ten-file-limit exception.
  • Assignment / checkpoint: Issue-linked branch and this PR; no managed Work/model assignment is used for this cleanup.
  • Actor: Codex desktop agent in the maintainer-directed Cordis migration chat.
  • Human authority: @adrianwebb.
  • Agent / capacity provider: OpenAI Codex desktop; real Work/model execution remains deferred to Task 10.
  • Exact base ref: cordis at c3287671197c589f83983ad89bbd4b4abc7847ed.
  • Exact head ref: feature/325-test-organization at 0454b6c752e4c16eedd15644e321f02e552a4c1b.

Contributor mode (select one):

  • Human-authored
  • Agent-assisted under human authority
  • Agent-authored under human authority

Plan

Documentation first, failing layout regressions, preserve/split existing cases, then check/build/complete program verification. The parser's real Cordis construction belongs in integration; no redundant unit tests are invented. Shared acceptance assertions live in their acceptance contract; support contains fixture setup.

Changes and commits

Update AGENTS.md, release-workflow, class-based layout guard, complete-tier scripts, CI partition labels, correspondence evidence and owner changelog. No runtime source or frozen dependency archive changes.

Verification

  • Exact source diff, predecessor registrations/bodies/arguments/timeouts and unchanged runtime/pin boundaries reviewed.
  • Discovery regressions observed failing before the guard fix and passing after it; strict owner checks and applicable focused regressions passed.
  • Conflicting writing-plans smoke paths reproduced by a failing policy regression, then corrected to acceptance in all nine copies. Both updated skills pass structural validation.
  • Six layout regressions now cover location, naming, complete tier commands and exhaustive/disjoint/nonempty CI name partitions.
  • Final current-head required CI verified before merge: completed successful PR workflow.

Portfolio inventory: 423 registrations = 374 preserved predecessors + 48 layout regressions + one planning-guide regression. CLI's isolated unit tier is explicitly empty; Agent is setup-only. Existing full qualification predates these review corrections, so fresh current-head CI is required.

Risk and rollback

Primary risk is discovery or fixture imports; complete program matrices, layout checks and body correspondence cover it. Before merge, close this candidate to abandon it; cordis is unchanged. After a future merge, read this PR's exact merge commit with gh pr view 326 --repo treeseed-ai/cli --json mergeCommit and revert that verified commit through a new reviewed cordis issue branch. Preserve legacy refs and runtime data.

Completion summary

Implementation and full branch verification complete. PR checks passed; awaiting maintainer review. Task 3D runtime implementation stays held. Keycloak identity, owner boundaries and all issues including Platform #678 remain intact/open; no release or cutover.

Submission checklist

  • The change is bounded to the stated work item and target repository.
  • Exact base and head refs are recorded and the branch is ready for review.
  • Verification and compatibility evidence are recorded above.
  • No plaintext secrets, credentials, machine state, or unrelated residue are included.
  • Plan, status, commits, and completion summary form a complete durable record.
  • Rollback or recovery steps are documented and executable.

Parent review and full owner map: treeseed-ai/platform#771.

Review correction: complete tier commands and exhaustive/disjoint/nonempty CI case partitions are now enforced. All issues stay open. The maintainer has authorized merge and verified task-branch cleanup, followed by Task 3D resumption with real Work/model execution deferred to Task 10.

The maintainer explicitly authorized review, resolution, merge to cordis and cleanup of verified merged task branches, followed by Task 3D resumption. All issues stay open; real Work/model execution remains deferred to Task 10.

Final CI read-back: the exact-head PR workflow reports completed/success. The aggregate gate and complete program logs passed. Several individual job snapshots retained an older in-progress status after their complete zero-failure logs were available; fresh workflow-level read-back confirms successful completion. Cancelled duplicate push runs are historical and are not the accepted PR qualification.

Copy link
Copy Markdown
Contributor Author

Review complete: all predecessor cases/bodies, helper/export paths, test discovery, instructions and runtime/frozen artifact boundaries were inspected. Fixed complete tier selectors, CI partition omissions and conflicting planning examples with observed red/green regressions. Current-head PR workflow https://github.com/treeseed-ai/cli/actions/runs/40519003328 reports completed/success; required aggregate and actual program logs passed. Stale individual-job metadata was checked against complete zero-failure logs and fresh workflow read-back. No unresolved findings; maintainer authorized merge and verified task-branch cleanup. All issues remain open.

@adrianwebb
adrianwebb merged commit 7225330 into cordis Oct 27, 2026
10 of 19 checks passed
@adrianwebb
adrianwebb deleted the feature/325-test-organization branch October 27, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant