Repository navigation
refactor: organize permanent tests and enforce tier policy (#325) - #326
Merged
Merged
Conversation
This was referenced Oct 27, 2026
Contributor
Author
|
Review complete: all predecessor cases/bodies, helper/export paths, test discovery, instructions and runtime/frozen artifact boundaries were inspected. Fixed complete tier selectors, CI partition omissions and conflicting planning examples with observed red/green regressions. Current-head PR workflow https://github.com/treeseed-ai/cli/actions/runs/40519003328 reports completed/success; required aggregate and actual program logs passed. Stale individual-job metadata was checked against complete zero-failure logs and fresh workflow read-back. No unresolved findings; maintainer authorized merge and verified task-branch cleanup. All issues remain open. |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Organize permanent CLI tests into acceptance, regression, integration and unit tiers, preserving the built executable behavior while enforcing permanent layout and complete discovery.
Work authority
cordisatc3287671197c589f83983ad89bbd4b4abc7847ed.feature/325-test-organizationat0454b6c752e4c16eedd15644e321f02e552a4c1b.Contributor mode (select one):
Plan
Documentation first, failing layout regressions, preserve/split existing cases, then check/build/complete program verification. The parser's real Cordis construction belongs in integration; no redundant unit tests are invented. Shared acceptance assertions live in their acceptance contract; support contains fixture setup.
Changes and commits
Update AGENTS.md, release-workflow, class-based layout guard, complete-tier scripts, CI partition labels, correspondence evidence and owner changelog. No runtime source or frozen dependency archive changes.
Verification
Portfolio inventory: 423 registrations = 374 preserved predecessors + 48 layout regressions + one planning-guide regression. CLI's isolated unit tier is explicitly empty; Agent is setup-only. Existing full qualification predates these review corrections, so fresh current-head CI is required.
Risk and rollback
Primary risk is discovery or fixture imports; complete program matrices, layout checks and body correspondence cover it. Before merge, close this candidate to abandon it;
cordisis unchanged. After a future merge, read this PR's exact merge commit withgh pr view 326 --repo treeseed-ai/cli --json mergeCommitand revert that verified commit through a new reviewedcordisissue branch. Preserve legacy refs and runtime data.Completion summary
Implementation and full branch verification complete. PR checks passed; awaiting maintainer review. Task 3D runtime implementation stays held. Keycloak identity, owner boundaries and all issues including Platform #678 remain intact/open; no release or cutover.
Submission checklist
Parent review and full owner map: treeseed-ai/platform#771.
Review correction: complete tier commands and exhaustive/disjoint/nonempty CI case partitions are now enforced. All issues stay open. The maintainer has authorized merge and verified task-branch cleanup, followed by Task 3D resumption with real Work/model execution deferred to Task 10.
The maintainer explicitly authorized review, resolution, merge to cordis and cleanup of verified merged task branches, followed by Task 3D resumption. All issues stay open; real Work/model execution remains deferred to Task 10.
Final CI read-back: the exact-head PR workflow reports completed/success. The aggregate gate and complete program logs passed. Several individual job snapshots retained an older in-progress status after their complete zero-failure logs were available; fresh workflow-level read-back confirms successful completion. Cancelled duplicate push runs are historical and are not the accepted PR qualification.