Skip to content

fix: preview retained acting continuation through canonical graph - #664

Merged
adrianwebb merged 2 commits into
stagingfrom
codex/retained-acting-continuation
Oct 30, 2026
Merged

adrianwebb merged 2 commits into
stagingfrom
codex/retained-acting-continuation

Conversation

@adrianwebb

Copy link
Copy Markdown
Contributor

Outcome

A simulation continuation previews the failed actor after a completed, reviewed prefix through the canonical execution graph. Successful products and review chronology remain attached to their original lineage.

Work authority

  • Work item / Issue: Resolve the frozen review candidate across admission and receipt ordering #625 ; retained delivery also tracked in Complete simulation upstream parity through the ordinary Releaser workflow deployment#913.
  • Proposal / decision: SDK assignment_QfUxLWHi8QRgL6FX4E-_uDnB8ScMYn0G:proposal v17 / Decision9c5a4d90-8ef9-4999-a281-b6bc938945d5; accepted scope, all five own estimates and profile3070248 remain unchanged.
  • Assignment / checkpoint: closed workday82189d57-c031-40f5-ba1f-26899bac4f78; failed Writer assignment_voF0oxCidqSfiN_IslVXSw2OTfqGbtZw/result3d5f99d26e85b153647b6991; fresh continuation5c0ccdb5-ab4a-4ba0-86e1-300480f9b46a selected zero and was not started. Historical authority deadline11:28UTC and capacity hard deadline08:30:08.650UTC remain unchanged.
  • Actor: Codex coordinator under the repository owner's standing recovery instruction.
  • Human authority: @adrianwebb (standing single retained delivery and actual-blocker code-only bootstrap; Platform Architecture author-all-first: continuous owner test matrices after schedule removal #489).
  • Agent / capacity provider: coordinator implementation. API Architect source discussion951e6/followup4e3857 confirmed the continuation gap; SDK Architect and Writer discussionbe79ff4bb6d90e8d62ce2c0d73913455 agreed to failed Writer then original chain with the reviewed prefix preserved. No agent implementation or independent review credit claimed.
  • Exact base ref: staging @ 36cd4e8, freshly fetched before rebase/submission.
  • Exact head ref: codex/retained-acting-continuation @ 58dc771

Contributor mode (select one):

  • Human-authored
  • Agent-assisted under human authority
  • Agent-authored under human authority

Plan

Reproduce zero selection after normal closure, reuse existing canonical source/lineage/review interpretation for a read-only prospective simulation workday, then qualify the exact candidate before supported adoption and continuation. No completed Architect replay, stale retry, forced-ready edit, copied product or plan reapproval.

Changes and commits

  • b0a6cec (original test-first7a84e88): reproduce empty continuation after completed/reviewed prefix.
  • 58dc771 (original09f188): preview through existing reconcileExecutionGraphOnce, returning before persistence; preserve already-derived internal workday identity for the prospective applied plan. Public caller-derived IDs stay forbidden.
  • Use prospective ready nodes only for simulation continuations, followed by existing project/proposal/Decision/activity checks. Production continuation selection unchanged.
  • Real SQL projection test retains original request-changes/correction/approval chronology, exact products, concurrent read consistency and immutable history. Unsettled leases and blocking questions still deny progress.
  • Three cases bound to the existing coded component registry. No new schema, authority store, continuation model, MCP route or execution wrapper.
  • Clean rebase onto qualified API663 protected head; git range-diff confirms both patches unchanged. Original and rebased final trees are identical26e25ed4b04b4b2cd04dc922090ccb7dd1eb3139.

Verification

  • Test-first:1failed/28deselected; complete red log SHA256e08f65c3425b747e762529eb27704dbfef93e50b7452702be012fadf6deb6911.

  • Local30selection unit passed, logd3f318db3c9b16394ef5628b1bebbe0f15b8b73b382b729f2eb7fc9f94a08eb6; existing public-service/SQL suite18passed, log8b900663f33b0162b9357c010fb88306ded28fe7f74a62e454211ea5267a0551.

  • Focused canonical SQL projection:1passed/15filtered, loga1bdc10d720d53f9c74fb7d2346c5eb4d8a8b0e8cb39d9637223bddb6efac131. Source endpoints and historical statuses/results are controlled fixture inputs; this is not genuine TreeDX/model/charge/settlement/physical-cleanup proof.

  • npm run build:dist passed, loga6db69154dfbcb0b066a2a62e57de2c396aac5ca20fb0244d69e7f05d0e4c063. npm run check:file-lengths including architecture passed, log201613fce20dd9d2ba19e8c38449fc001a519deb969302a570ca23d59ef88404. git diff --check passed.

  • Initial fixture missing-inbox migration and compiled20% planning mismatch failures retained and corrected with existing migration/intended allocation0; no assertion, deadline or allowance weakened.

  • Full exact-candidate API/real PostgreSQL/native TreeDX prerequisites and coded component qualification: Pending this original Actions run. No local scene or changed-runtime coaching launched. Local focused checks are additional evidence, not full prerequisites.

  • I ran the narrowest relevant package verification and documented any checks that could not be run.

Risk and rollback

Prospective projection must retain exact source custody, lineage, profile and review-cycle denials. It writes no graph/workday state; creation still revalidates authority. Roll back through an ordinary revert PR of58dc771ffdd5de2addc1a281cc9c55f29389a0c4, qualify and adopt through supported trsd. Preserve prior snapshots, products, reviews, estimates, deadlines, failures and unrelated development selections.

Completion summary

Focused regression, SQL coverage and minimum implementation are complete. Full qualification, normal expected-head merge, supported adoption and actual native MCP Writer continuation remain pending. Retained corrected/approved Architect product147d852a279b38f58184ce7e494b6dc59784fdb2 is not integrated. Ordinary simulated releases remain0. API663 merged normally; its adoption is separate and in progress.

AGPL committer authorization

The trusted base workflow checks the provider-authenticated PR author against the repository allowlist. No credential, spoofed identity or per-PR approval attestation is supplied.

Submission checklist

  • The change is bounded to the stated work item and target repository.
  • Exact base and head refs are recorded and the branch is ready for review.
  • Verification and compatibility evidence are recorded above.
  • No plaintext secrets, credentials, machine state, or unrelated residue are included.
  • Plan, status, commits, and completion summary form a complete durable record.
  • Rollback or recovery steps are documented and executable.

@adrianwebb
adrianwebb merged commit 45bd3d5 into staging Oct 30, 2026
3 checks passed
@adrianwebb
adrianwebb deleted the codex/retained-acting-continuation branch October 30, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant