Repository navigation
fix: retain shared proposal context in acting and review - #662
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Acting and reviewing inherit the exact proposal-level objective, evidence and discussion context needed to execute their accepted work. A TreeDX-output Architect currently loses the declared Git source and fails before model execution.
Work authority
Work item / Issue: Resolve the frozen review candidate across admission and receipt ordering #625 and Complete simulation upstream parity through the ordinary Releaser workflow deployment#913; same retained delivery.
Proposal / decision: Deployment assignment_Ms4bx5oD3iZXXvNg4ni-2sp0Pno4iJmk:proposal v21 / ba3c8d9d-4097-4e7d-8cc1-64a2106f0763 are the observed blocked work, not authority to rewrite it.
Assignment / checkpoint: failed assignment_azTNw-gtsy-l2GaKvNUgbDQw--mt5ACN; original snapshots and deadline retained.
Actor: Codex coordinator using provider-authenticated GitHub account adrianwebb.
Human authority: @adrianwebb authorized the one-time code-only backend/MCP bootstrap for actual governed-execution blockers.
Agent / capacity provider: Codex desktop coordinator; no invented TreeSeed implementation assignment.
Exact base ref: staging / 7060f4e
Exact head ref: codex/acting-proposal-context / 25d34bd
Human-authored
Agent-assisted under human authority
Agent-authored under human authority
Plan
Reproduce missing shared context, reuse the existing projection for the selected work item, qualify this exact candidate, then adopt through supported trsd and resume MCP recovery. Full qualification and live repair are pending; no issued authority is replaced.
Changes and commits
Test-first13d79fde1b reproduces the lost refs. 25d34bd reuses the shared reference projection while preserving selected-item source priority, hash/identity/binding validation, profile ceilings and output custody. Peer workspace references remain excluded. Adds no schema, persistence, endpoint or execution path.
Verification
Validation: test-first 13d79fd reproduces the dropped refs (1 selected failure; red log SHA472aaed18022642239c4a564a7f2f717a40556c0e0beb7bbba0ed69ca60d8a10). Final7focused tests/2files pass, including real owning SQL, committed Git bytes, official HTTP reads, typed TreeDX grants, exact readback, immutable input, peer exclusion and permission denial. Strict build, structural policies and whitespace pass. Existing original negative cases and budgets remain. Two new cases are bound in the existing coded component scene; full exact-candidate qualification and live recovery remain pending Actions.
The broader local caller invocation retained95passes/4failures:3required disposable-PostgreSQL environment failures and1new fixture aliasing failure, corrected without changing assertions. Earlier focused native fixture whitelist/schema failures are retained; the fixture now supports only bounded objective/discussion paths and retains traversal denials. A final policy attempt failed after its temporary dependency link was removed too early; restored dependencies produced a passing final run, then the link was removed after completion. No local full-suite/scene pass is claimed.
Source SHA c9d39d73a91984352c4a2b9ee2dc26870381d9523a6ae301914068c33d00a2fa; unit3373cf8ad4cac0c46ef02b6dd626a0f73dd129c3f2b3db3f74c20c4a40dee318; native311a509434bde20afdca1336e80cd2ad184da963231b1e65b3f3b001ae98f86b. Final focused logf2168dd2cdf61453a991dd4c014fc419e8f54a6af8758b267e7bcdcd35c7db9b.
The first submission-contract check failed because my description omitted this required template. This corrected body preserves the original failed check; its edited-event check is separate. The original expensive Verify41005862235/job123900496489 is preserved without rerun.
Risk and rollback
Shared context must not import peer write custody or override the selected source. Exact-output unit checks and real SQL/Git/HTTP grant/readback cases cover these boundaries; full component verification remains pending. No migration is required. Roll back through a normal checked revert PR restoring the prior projection, followed by supported trsd adoption. Preserve all attempts/results and stop only affected workdays before any runtime replacement.
Completion summary
Local regression and narrow owning checks pass; full exact-candidate Actions and governed live retry remain unproved. The cohort is0team/19coordinator=0%, ordinary simulated releases0. This bootstrap adds one coordinator integration only if merged. No team-product credit is claimed.
AGPL committer authorization
The base-owned workflow checks the provider-authenticated PR author against the existing allowlist. No committer policy or identity change.
Submission checklist