Repository navigation
fix: retain source-derived Decision conditions after workday closure - #661
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Closing a selected simulation before any approved acting assignment can retire its accepted-Decision condition as stale. A fresh Decision-selected workday then has zero demands, while continuation correctly refuses a lineage with no executed Decision. Keep conditions source-derived; retain existing workload retirement and continuation checks.
Work authority
Contributor mode (select one):
Plan
Reproduce the actual stale condition, change only the terminal-workload retirement guard, extend original native Decision/public-preflight coverage and coded scenes, qualify the exact candidate, adopt through supported composition, then resume the original approved group work through MCP. No empty workday, repeated approval, copied estimates, forced state or deadline change.
Changes and commits
Verification
Risk and rollback
Conditions must remain blocked if current authority or feedback denies execution. Source-derived completion must not thaw acting/reviewing attempts or replace historical issued grants. Original custody and continuation checks stay intact. Roll back by a normally checked revert PR and supported API rebuild, preserving products, Decisions, workdays and unknown usage; no migration or private-state repair.
Completion summary
Reproduced the exact condition-retirement bug and implemented the minimum owner repair. Full qualification and live recovery remain unproved. Current recovery ratio0team/18coordinator=0%; this PR adds a coordinator integration only after merge. Native simulated releases0.
AGPL committer authorization
The base-owned workflow checks provider-authenticated author adrianwebb against the existing approved list. No authorization-policy change or spoofed identity.
Submission checklist