Skip to content

fix: retain source-derived Decision conditions after workday closure - #661

Merged
adrianwebb merged 2 commits into
stagingfrom
codex/condition-retirement
Oct 30, 2026
Merged

adrianwebb merged 2 commits into
stagingfrom
codex/condition-retirement

Conversation

@adrianwebb

Copy link
Copy Markdown
Contributor

Outcome

Closing a selected simulation before any approved acting assignment can retire its accepted-Decision condition as stale. A fresh Decision-selected workday then has zero demands, while continuation correctly refuses a lineage with no executed Decision. Keep conditions source-derived; retain existing workload retirement and continuation checks.

Work authority

  • Work item / Issue: Resolve the frozen review candidate across admission and receipt ordering #625; same retained delivery prerequisite in Complete simulation upstream parity through the ordinary Releaser workflow deployment#913.
  • Proposal / decision: Deployment assignment_Ms4bx5oD3iZXXvNg4ni-2sp0Pno4iJmk:proposal v21 / ba3c8d9d-4097-4e7d-8cc1-64a2106f0763 are the incident subject, not authority for this API bootstrap.
  • Assignment / checkpoint: adrianwebb's standing one-time code-only backend/MCP bootstrap authorization for actual blockers. API Architect inspected exact493 in native discussion send-fc8b6aca47540761f562d472596c4dad / assignment_e9OsQcabF8HVDENwxmFxjjqVfx2YvuAh / response-1db5a5a36f83a3a26660eb75 and independently confirmed the unfiltered condition branch.
  • Actor: Codex coordinator under adrianwebb.
  • Human authority: adrianwebb.
  • Agent / capacity provider: coordinator bootstrap; no TreeSeed acting assignment or team implementation credit.
  • Exact base ref: staging493a75db4419ca403674f69710aad347518923e2; fresh protected fetch before branching.
  • Exact head ref: codex/condition-retirement e78e078.

Contributor mode (select one):

  • Human-authored
  • Agent-assisted under human authority
  • Agent-authored under human authority

Plan

Reproduce the actual stale condition, change only the terminal-workload retirement guard, extend original native Decision/public-preflight coverage and coded scenes, qualify the exact candidate, adopt through supported composition, then resume the original approved group work through MCP. No empty workday, repeated approval, copied estimates, forced state or deadline change.

Changes and commits

  • Test-first84db8f00a6: original state reconciliation returns stale instead of current completed/blocked condition; 2failed/3passed.
  • e78e078: one production guard skips condition nodes. Existing source-status reconciliation and predecessor checks evaluate authority/feedback; acting/reviewing authority and issued custody paths are unchanged.
  • Unit coverage includes already-stale/current conditions, issued-history presence, immutability/reconciliation convergence, noncurrent Decision and unresolved feedback denial.
  • Extend the existing native TreeDX/real PostgreSQL Decision case with controlled pre-acting closed-state INPUT, concurrent reconciler, read-only preview and fresh public simulation preflight with planningPercent0. The actual governed Decision, original estimate rows, closed parent, usage/ledger and assignments remain unchanged. This fixture does not claim a managed workday executed or settled.
  • Bind both new cases in the existing coded component scene. No new model, schema, store, operation, runner or execution path.

Verification

  • Test-first original failure: 2failed/3passed, log SHA7fbfef286d4a0277af43737fbaee72b630737c2f000ec10aedb442b861418082.
  • Local focused/caller invocation:32passed/1FAILED across3files. Both new condition cases and graph callers pass. The existing native continuation case fails because TREESEED_TEST_POSTGRES_URL is absent; do not count this invocation as native/full success. Log SHA27710cb41bd9f57906ff7a3de569fa9f6fd33744ebd8d9fa44f3d196e99ea5e6. The unchanged required CI disposable PostgreSQL environment must supply native proof.
  • npm run build:dist PASSED strict build, log SHAa6db69154dfbcb0b066a2a62e57de2c396aac5ca20fb0244d69e7f05d0e4c063.
  • npm run check:file-lengths / architecture policy and git diff --check PASSED; structurelog SHA201613fce20dd9d2ba19e8c38449fc001a519deb969302a570ca23d59ef88404.
  • Exact source SHAs: productionfedeedfbcd8cb0dceda3c5443083c2d569709a457c48575a834293238ee0060b; unit4a69fe8806dd66c777e0cbd4a41f5dce4e2db0760f6eaede70111a5d4c4e8ea5; nativehelperbd957ed88a343ff481fa294b2f2400bb730484958be0bce47d5a5c4e012a18a9.
  • Full required native prerequisites, complete participating-owner suites, coded component scenes, exact-candidate adoption and live recovery: PENDING. Existing30s native Decision and120s verifier budgets unchanged. No skipped prerequisite, weakened assertion or duplicate campaign.
  • I ran the narrowest relevant package verification and documented any checks that could not be run.

Risk and rollback

Conditions must remain blocked if current authority or feedback denies execution. Source-derived completion must not thaw acting/reviewing attempts or replace historical issued grants. Original custody and continuation checks stay intact. Roll back by a normally checked revert PR and supported API rebuild, preserving products, Decisions, workdays and unknown usage; no migration or private-state repair.

Completion summary

Reproduced the exact condition-retirement bug and implemented the minimum owner repair. Full qualification and live recovery remain unproved. Current recovery ratio0team/18coordinator=0%; this PR adds a coordinator integration only after merge. Native simulated releases0.

AGPL committer authorization

The base-owned workflow checks provider-authenticated author adrianwebb against the existing approved list. No authorization-policy change or spoofed identity.

Submission checklist

  • The change is bounded to the stated work item and target repository.
  • Exact base and head refs are recorded and the branch is ready for review.
  • Verification and compatibility evidence are recorded above.
  • No plaintext secrets, credentials, machine state, or unrelated residue are included.
  • Plan, status, commits, and completion summary form a complete durable record.
  • Rollback or recovery steps are documented and executable.

@adrianwebb
adrianwebb merged commit 7060f4e into staging Oct 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant