Skip to content

refactor: organize permanent tests and enforce tier policy (#146) - #147

Merged
adrianwebb merged 6 commits into
cordisfrom
feature/146-test-organization
Oct 27, 2026
Merged

adrianwebb merged 6 commits into
cordisfrom
feature/146-test-organization

Conversation

@adrianwebb

@adrianwebb adrianwebb commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Organize permanent tests under tests/acceptance, tests/regression, tests/integration and tests/unit, splitting mixed suites and preserving every predecessor case. Update fixture paths, complete-tier discovery, AGENTS.md/release-workflow policy and executable layout checks together.

Runtime source, frozen archives and Keycloak identity are preserved. The maintainer explicitly approved one atomic owner PR as a scoped exception to the ten-file limit.

Acceptance criteria

  • Preserve all 9 existing registrations, arguments, explicit timeouts and assertion counts.
  • Add six adversarial layout regressions; reject misplaced/hidden specifications and incomplete tier discovery.
  • Update instructions and owner changelog; preserve repository boundaries and all open issues.

Verification

  • Exact source diff, predecessor registrations/bodies/arguments/timeouts and unchanged runtime/pin boundaries reviewed.
  • Discovery regressions observed failing before the guard fix and passing after it; strict owner checks and applicable focused regressions passed.
  • Conflicting writing-plans smoke paths reproduced by a failing policy regression, then corrected to acceptance in all nine copies. Both updated skills pass structural validation.
  • Six layout regressions now cover location, naming, complete tier commands and exhaustive/disjoint/nonempty CI name partitions.
  • Final current-head required CI verified before merge: verify.

Portfolio inventory: 423 registrations = 374 preserved predecessors + 48 layout regressions + one planning-guide regression. CLI's isolated unit tier is explicitly empty; Agent is setup-only. Existing full qualification predates these review corrections, so fresh current-head CI is required.

Related

Part of #146. Portfolio: treeseed-ai/platform#768.
Task 3D runtime implementation remains held for cleanup review. All issues, including Platform #678, stay open under release policy.
Parent review and full owner map: treeseed-ai/platform#771.

Review correction: complete tier commands and exhaustive/disjoint/nonempty CI case partitions are now enforced. All issues stay open. The maintainer has authorized merge and verified task-branch cleanup, followed by Task 3D resumption with real Work/model execution deferred to Task 10.

Reviewed refs

  • Base: cordis at f7974ca6e24491edc5aa617f44e20b5282022dc0.
  • Head: feature/146-test-organization at 472be30cb36be1c389e8118e707192f83450d966.

The maintainer explicitly authorized review, resolution, merge to cordis and cleanup of verified merged task branches, followed by Task 3D resumption. All issues stay open; real Work/model execution remains deferred to Task 10.

Copy link
Copy Markdown
Contributor Author

Review complete: source/test/metadata diff, all predecessor cases and body correspondence, public helper exports/discovery and unchanged runtime/frozen artifacts verified. Fixed complete-directory/CI partition validation and conflicting planning examples with observed red/green tests. Current-head CI is green; API authorization remains intact. No unresolved findings. Maintainer authorized merge to cordis and verified task-branch cleanup; all issues stay open.

@adrianwebb
adrianwebb merged commit 362ab46 into cordis Oct 27, 2026
1 of 2 checks passed
@adrianwebb
adrianwebb deleted the feature/146-test-organization branch October 27, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant