Repository navigation
fix: resolve Node asset package boundaries (#137) - #142
Merged
Merged
Conversation
# Conflicts: # CHANGELOG.md # README.md
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Resolve built Node asset dependencies across nested module-mode boundaries without losing package identity or asset-integrity checks.
Part of #137 and treeseed-ai/platform#726. Stacked continuation of #141; predecessor changes are present for candidate execution. Review this six-file increment against #141.
Work authority
Contributor mode (select one):
Plan
Docs → built Node default-construction red → matching-name package-root traversal → complete owner verification.
Changes and commits
Six-file continuation after #141: carry the requested dependency name while traversing entry ancestry; ignore type-only nested manifests; rebuild private Admin .7 and its browser identity together.
Verification
bun run verify: clean semantic/type/build checks; 8 tests (2 unit, 2 integration, 4 smoke), zero failures. The new built Node default catalog smoke failed with ASSET_PACKAGE_UNAVAILABLE before the fix and passes with genuine installed Postgres afterward. Firefox HTTPS explicit fixture-CA browser smoke passes. Archive .7 SHA-2562041d42294bcd5814dc0a481bcc5a95b583ca4ba2a201b46d72a8f0c57979132. Both exact-head Ubuntu 26.04 CI verify runs passed; genuine installed Keycloak/API assembly remains pending.Risk and rollback
Private migration candidate. No production publication or cutover; preserve legacy branches and installations. Before merge, close or amend this draft without integration effects. After an authorized merge, revert its exact squash commit through a separate reviewed cordis PR; retain any durable records and require explicit repair instead of deleting uncertain state. Keep every issue, including Platform #678, open under release policy.
Completion summary
Bounded candidate submitted as draft. Parent Task 3C owner adoption, installed activation/source management and assembled acceptance remain pending. No claim of completed Task 3C or active user installation.
Submission checklist