Repository navigation
Collect source text from ParseCallback during parsing - #178
Merged
ObserverOfTime merged 1 commit intoNov 10, 2026
Merged
ObserverOfTime merged 1 commit into
ObserverOfTime merged 1 commit into
Conversation
Author
|
Thanks for taking a look. From my diff, the intended changes in
I don’t think I changed the null-language check itself. Were you pointing to a specific issue with the added |
Author
|
Good point. I switched this to collect bytes instead of using a StringBuilder, and I also used the callback offset to avoid duplicating overlapping chunks. |
ObserverOfTime
force-pushed
the
collect-parsecallback-source-text
branch
2 times, most recently
from
November 10, 2026 15:55
c36a49c to
a35a7ec
Compare
Co-Authored-By: ObserverOfTime <chronobserver@disroot.org>
ObserverOfTime
force-pushed
the
collect-parsecallback-source-text
branch
from
November 10, 2026 16:02
a35a7ec to
36e302a
Compare
Member
|
Thanks, I made a few changes to pass the result as bytes instead of converting to a string. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change collects source text returned by
ParseCallbackduring parsing and stores it in the resultingTree.Previously, trees created from
ParseCallbackdid not retain source text, causing methods likegetText()andNode.getText()to returnnull. This change enables text-related APIs for callback-based parsing.This also updates the callback parsing test to assert the new behavior.
Fixes #126