Repository navigation
Keep Necto running when the last window is closed - #43
Merged
Merged
Conversation
Closing the last window quit the app, which also closed the control socket, so necto-cli had nothing to talk to until the app was opened again. The last window now hides instead of closing. The app keeps serving the CLI and connected apps, and the Dock icon brings back the same window with its selection and panels intact. Other windows still close, and Command-Q still quits. SwiftUI owns the window's delegate, so a forwarding delegate answers only the close question and passes everything else on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closing Necto's last window quit the app. That also closed the control socket, so
necto-cli, and any agent driving Necto through it, failed until someone opened the app again.The last window now hides instead of closing:
SwiftUI has no way to hide a
WindowGroupwindow on close, and it owns the window's delegate.NectoCloseInterceptorstands in front of that delegate, answerswindowShouldCloseand forwards everything else.Changelog
Closing the last window no longer quits Necto. The window hides, the CLI keeps working, and the Dock icon brings the window back.
Test Plan
xcodebuild -project Necto.xcodeproj -scheme Necto -configuration Debug -destination 'platform=macOS' build:** BUILD SUCCEEDED **script/test native:** TEST SUCCEEDED **,all tests passedNot verified:
necto-clicalls while the window is hiddenNo screenshots: nothing changes visually.