Repository navigation
Fix ECR artifact verification when retries add immutable tags - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrying AV Scanner and Opportunities publishes a new immutable release tag for an image digest already in ECR. In the observed AWS responses,
BatchGetImageby digest returned one image record per tag. The deployer required exactly one record and stopped withCannot verify pushed imagebefore deployment.Resolve the exact immutable release tag, then require the returned tag and digest to match the release identity before verifying the image configuration digest and scan. This preserves artifact identity and the single-image response check while allowing multiple tags to refer to the same immutable image.
Validation: all 100 tests pass offline in the pinned CircleCI AWS executor. The regression reproduces ECR's multiple-record digest lookup and verifies the exact-tag path, plus rejection of missing/mismatched tag/digest identities. Read-only checks against the affected dev images returned two records by digest and exactly one matching record by release tag.
Release as v2.0.8 after merge; affected application PRs will pin the tag and exact merged commit. IAM fixes for the original AV Scanner and Opportunities failures are already applied in dev through private IaC. The Payload-dev-only scan policy from v2.0.7 remains unchanged.