Repository navigation
Keep unverified members signed out of platform applications - #2598
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat missing, false, malformed, or conflicting email-verification claims as signed out before exposing a token to profiles, route guards, or authenticated API requests. Accept only boolean true verification from the standard or exact trusted Topcoder claims. Unverified members retain public browsing; existing signed-in guards block onboarding, account settings, Review, Wallet, Work, customer/admin/report applications, and authenticated actions.
Pin the updated accounts connector from topcoder-platform/tc-auth-lib#375 and update yarn.lock. The accounts companion handles activation messaging and rejects unverified login/refresh cookies. Server-side enforcement is provided by topcoder-platform/tc-core-library-js#10 and the identity API companion; browser decoding is not a replacement for signature verification.
Validation: 30 focused authentication, XHR, and route-policy tests pass; changed-file ESLint passes. Tests cover verified sessions, missing/false/non-boolean claims, spoofed namespaces and machine flags, malformed tokens, and suppressing refresh scheduling for rejected sessions. The full application build/test suite was not run.