Skip to content

[PROD] release PM-6686 - spacetech landingpage - #13

Merged
vas3a merged 2 commits into
masterfrom
PM-6686_prod-release-spacetech-landingpage
Nov 4, 2026
Merged

vas3a merged 2 commits into
masterfrom
PM-6686_prod-release-spacetech-landingpage

Conversation

@vas3a

@vas3a vas3a commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

This pull request introduces two main updates: it revises how sales reply-to addresses are handled (now supporting multiple reply-to addresses, all of which receive replies), and it adds support for a new SpaceTech challenge notification flow with configurable recipients and template. Documentation, configuration, and tests are updated to reflect these changes.

Sales Reply-to Handling Improvements

  • All LETS_TALK_SALES_REPLY_TO addresses are now set as reply-to (using SendGrid's reply_to_list), so replies from prospects go to every address; no addresses are copied as CC. This is reflected in the code, configuration, and documentation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

SpaceTech Challenge Notification Flow

  • Adds a new internal notification flow for SpaceTech challenge submissions (space-tech-challenge-email), with recipients and template ID set via SPACE_TECH_CHALLENGE_RECIPIENTS and SPACE_TECH_CHALLENGE_TEMPLATE_ID config variables. The submitter's email is used as reply-to. Documentation and deployment scripts are updated accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Documentation Updates

  • All relevant documentation files (README.md, ADRs, email docs) are updated to describe the new sales reply-to logic and the SpaceTech challenge notification flow, including configuration and operational instructions. [1] [2] [3] [4] [5] [6]

Configuration and Deployment

  • Environment variable examples, config schemas, and deployment scripts are updated to include the new SpaceTech challenge settings and revised sales reply-to handling. [1] [2] [3] [4] [5]

Testing Enhancements

  • Test cases are added and updated to verify the new reply-to logic (including deduplication and single/multiple address handling) and to ensure invalid configurations are rejected. [1] [2] [3] [4]

@vas3a
vas3a requested review from jmgasper and a balanced review from Copilot November 4, 2026 08:22
@vas3a vas3a changed the title Pm 6686 prod release spacetech landingpage [PROD] release PM-6686 - spacetech landingpage Nov 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.

🟡 Changes recommended

A moderate active issue remains because LETS_TALK_SALES_REPLY_TO can validate at startup with up to 1000 emails but later violate emailSettingsSchema.replyTo's 100-address cap, risking deferred deliveries due to invalid email settings unless the limit is enforced during config parsing.

1 open issue
What changed in this PR

Updates forms-processor-v6 email routing to support multiple trusted reply-to addresses (published as SendGrid reply_to_list via email-service-v6) and introduces a new SpaceTech landing page submission notification flow whose recipients/template are configured via environment/SSM.

Changes:

  • Publish multiple trusted replyTo addresses (deduped/lowercased) and stop using cc for sales replies.
  • Add SpaceTech challenge notification flow (space-tech-challenge-email) with env-driven recipients/template ID and submitter email as reply-to.
  • Update docs, deployment/config surfaces, and tests to cover the new behaviors and validation rules.
File Description
test/​space-tech-flows.test.ts Updated as part of this pull request.
test/​lets-talk.test.ts Updated as part of this pull request.
test/​actions.test.ts Updated as part of this pull request.
src/​space-tech-flows.ts Updated as part of this pull request.
src/​main.ts Updated as part of this pull request.
src/​lets-talk-flows.ts Updated as part of this pull request.
src/​config.ts Updated as part of this pull request.
src/​actions.ts Updated as part of this pull request.
README.md Updated as part of this pull request.
docs/​emails/​README.md Updated as part of this pull request.
docs/​adr/​0001-lets-talk-ai-classification-and-label-actions.md Updated as part of this pull request.
deploy/​release.py Updated as part of this pull request.
deploy/​README.md Updated as part of this pull request.
.env.example Updated as part of this pull request.

Review effort: Balanced

Comment thread src/config.ts
Comment on lines +66 to 69
/** The sales reply's reply-to addresses; all of them receive a prospect's reply. */
LETS_TALK_SALES_REPLY_TO: emailList(
"support@topcoder.com,test1@topcoder.com",
),
@vas3a
vas3a merged commit 9a6f1f7 into master Nov 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants