Repository navigation
[PROD] release PM-6686 - spacetech landingpage - #13
Merged
Merged
Conversation
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟡 Changes recommended
A moderate active issue remains because LETS_TALK_SALES_REPLY_TO can validate at startup with up to 1000 emails but later violate emailSettingsSchema.replyTo's 100-address cap, risking deferred deliveries due to invalid email settings unless the limit is enforced during config parsing.
1 open issue
What changed in this PR
Updates forms-processor-v6 email routing to support multiple trusted reply-to addresses (published as SendGrid reply_to_list via email-service-v6) and introduces a new SpaceTech landing page submission notification flow whose recipients/template are configured via environment/SSM.
Changes:
- Publish multiple trusted
replyToaddresses (deduped/lowercased) and stop usingccfor sales replies. - Add SpaceTech challenge notification flow (
space-tech-challenge-email) with env-driven recipients/template ID and submitter email as reply-to. - Update docs, deployment/config surfaces, and tests to cover the new behaviors and validation rules.
| File | Description |
|---|---|
| test/space-tech-flows.test.ts | Updated as part of this pull request. |
| test/lets-talk.test.ts | Updated as part of this pull request. |
| test/actions.test.ts | Updated as part of this pull request. |
| src/space-tech-flows.ts | Updated as part of this pull request. |
| src/main.ts | Updated as part of this pull request. |
| src/lets-talk-flows.ts | Updated as part of this pull request. |
| src/config.ts | Updated as part of this pull request. |
| src/actions.ts | Updated as part of this pull request. |
| README.md | Updated as part of this pull request. |
| docs/emails/README.md | Updated as part of this pull request. |
| docs/adr/0001-lets-talk-ai-classification-and-label-actions.md | Updated as part of this pull request. |
| deploy/release.py | Updated as part of this pull request. |
| deploy/README.md | Updated as part of this pull request. |
| .env.example | Updated as part of this pull request. |
Review effort: Balanced
Comment on lines
+66
to
69
| /** The sales reply's reply-to addresses; all of them receive a prospect's reply. */ | ||
| LETS_TALK_SALES_REPLY_TO: emailList( | ||
| "support@topcoder.com,test1@topcoder.com", | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request introduces two main updates: it revises how sales reply-to addresses are handled (now supporting multiple reply-to addresses, all of which receive replies), and it adds support for a new SpaceTech challenge notification flow with configurable recipients and template. Documentation, configuration, and tests are updated to reflect these changes.
Sales Reply-to Handling Improvements
LETS_TALK_SALES_REPLY_TOaddresses are now set as reply-to (using SendGrid'sreply_to_list), so replies from prospects go to every address; no addresses are copied as CC. This is reflected in the code, configuration, and documentation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]SpaceTech Challenge Notification Flow
space-tech-challenge-email), with recipients and template ID set viaSPACE_TECH_CHALLENGE_RECIPIENTSandSPACE_TECH_CHALLENGE_TEMPLATE_IDconfig variables. The submitter's email is used as reply-to. Documentation and deployment scripts are updated accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9]Documentation Updates
README.md, ADRs, email docs) are updated to describe the new sales reply-to logic and the SpaceTech challenge notification flow, including configuration and operational instructions. [1] [2] [3] [4] [5] [6]Configuration and Deployment
Testing Enhancements