Skip to content

refactor: simplify control and publisher bookkeeping - #808

Open
0xcadams wants to merge 2 commits into
0xcadams/cli-agent-guidefrom
0xcadams/cli-dependency-cleanup
Open

0xcadams wants to merge 2 commits into
0xcadams/cli-agent-guidefrom
0xcadams/cli-dependency-cleanup

Conversation

@0xcadams

Copy link
Copy Markdown
Member

What

Use existing Go libraries for database row collection, concurrent delivery, HTTP header syntax and nested test comparisons. Add an advisory report for changes to the public Go API.

Why

Each of these sites implemented a small library operation by hand. Fan-out must still try every receiver; database rollback still has its independent deadline.

Changes

  • Use pgx.CollectRows for single-column queries and a plain errgroup.Group for webhook fan-out.
  • Validate OTLP header names with httpguts and show certificate plan differences with go-cmp.
  • Compare the exported Go API with the last release tag in the GitHub Actions summary.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T15:00:10.886678Z f3ca7d2 New commits
🔒 Security Review ✅ Completed 2026-11-20T15:02:42.749867Z f3ca7d2 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@0xcadams
0xcadams added this pull request to stack #809 November 20, 2026 14:56
@0xcadams
0xcadams force-pushed the 0xcadams/cli-dependency-cleanup branch from 024589d to f3ca7d2 Compare November 20, 2026 14:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant