Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6833d8444
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| version := buildinfo.Line("tnl") | ||
| sections := []struct{ command, use string }{ | ||
| {"tnl status --scope local --output json", "Read the recorded local snapshot. A saved ready state is not a fresh readiness check."}, | ||
| {"tnl wait --service NAME --output json", "Check readiness now. Replace NAME with the configured service or invocation ID."}, |
There was a problem hiding this comment.
Restrict readiness guidance to configured service names
When automation follows this instruction using a publication's invocation ID, tnl wait rejects it instead of checking readiness. In the CLI implementation, waitCommand.Service documents “Check this service; repeat to select several,” and runAppWait in cmd/tnl/app_observation.go checks every supplied value against project.Config.Services, returning ServiceNotConfigured for an invocation ID. Without project configuration, runAppObservation rejects the command even earlier. Remove the invocation-ID alternative so both the human guide and generated skill describe inputs this binary actually supports.
Useful? React with 👍 / 👎.
a6833d8 to
cefc122
Compare
What
tnl agent-guideexplains how to check readiness, resume watches, read feedback and review production changes with the installed binary.--skillemits a SKILL.md file.Why
Recorded status is different from fresh readiness, and feedback and local event streams use different cursors. Automation needs those distinctions even when working offline.
Changes