Repository navigation
Load: Improve log message for UINT value out of range - #248
Merged
Merged
Conversation
tlsa
force-pushed
the
tlsa/uint-range-log-msg
branch
from
November 14, 2026 19:39
96b5760 to
3d0e42f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 97.24% 97.25% +0.01%
==========================================
Files 11 11
Lines 2283 2294 +11
Branches 502 506 +4
==========================================
+ Hits 2220 2231 +11
Misses 29 29
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Now it matches the other out of range messages.
We now reject leading whitespace. (It would have to be quoted to reach this point, e.g. " 10".) We also reject negative numbers in the UINT handling.
tlsa
force-pushed
the
tlsa/uint-range-log-msg
branch
from
November 14, 2026 20:40
3d0e42f to
939b952
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes handling of out-of-range and invalid integer values more consistent.
Closes: #247