Skip to content

android: switching library tabs no longer clears the multi-select selection (possible #225 regression) #456

Closed

Description

@timusus

The Maestro flow library-multiselect-back also asserted that switching library tabs clears an active selection (#225). While porting it to Robolectric (#450), the worker found each tab's ViewModel keeps its own selection and nothing clears it on tab switch (unverified on device). LibraryDestination needs Hilt, so no JVM test reaches it today. Decide the intended behaviour, fix, and cover it with a Hilt-backed Robolectric test or a device check on #452.

Activity

  1. timusus commented on Sep 26, 2026

    @timusus
    OwnerAuthor

    Decision: clear on tab switch only (#225). Clearing when the Library destination is disposed also fired on rotation and on pushing a detail pane on compact layouts, which wiped a live selection, so it was dropped (e5c40734d).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions